Andy Shevchenko
2022-Jan-14 15:17 UTC
[Nouveau] [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout
On Fri, Jan 14, 2022 at 03:07:21PM +0000, Simon Ser wrote:> On Friday, January 14th, 2022 at 15:16, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > > > Why not enum? > > There is no enum for DRM format modifiers.I'm not sure how this prevents to use enum in the code instead of const u64. Any specific reason for that? -- With Best Regards, Andy Shevchenko
Simon Ser
2022-Jan-14 15:42 UTC
[Nouveau] [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout
On Friday, January 14th, 2022 at 16:17, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote:> On Fri, Jan 14, 2022 at 03:07:21PM +0000, Simon Ser wrote: > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko <andriy.shevchenko at linux.intel.com> wrote: > > > > > Why not enum? > > > > There is no enum for DRM format modifiers. > > I'm not sure how this prevents to use enum in the code instead of const u64. > Any specific reason for that?I'm not sure how one would use an enum as the array item type, when there is no defined enum type. Moreover, all the rest of DRM uses uint64 for modifiers.