Javier Martinez Canillas
2021-Nov-05 12:00 UTC
[Nouveau] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled
On 11/5/21 11:04, Jani Nikula wrote:> On Fri, 05 Nov 2021, Javier Martinez Canillas <javierm at redhat.com> wrote:[snip]>> >> Do you envision other condition that could be added later to disable a >> DRM driver ? Or do you think that just from a code readability point of >> view makes worth it ? > > Taking a step back for perspective. > > I think there's broad consensus in moving the parameter to drm, naming > the check function to drm_something_something(), and breaking the ties > to CONFIG_VGA_CONSOLE. I appreciate the work you're doing to that > effect. >Thanks, I appreciate your feedback and comments.> I think everything beyond that is still a bit vague and/or > contentious. So how about making the first 2-3 patches just that? > Something we can all agree on, makes good progress, improves the kernel, > and gives us something to build on? >That works for me. Thomas, do you agree with that approach ? Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat
Thomas Zimmermann
2021-Nov-05 13:00 UTC
[PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled
Hi Am 05.11.21 um 13:00 schrieb Javier Martinez Canillas:> On 11/5/21 11:04, Jani Nikula wrote: >> On Fri, 05 Nov 2021, Javier Martinez Canillas <javierm at redhat.com> wrote: > > [snip] > >>> >>> Do you envision other condition that could be added later to disable a >>> DRM driver ? Or do you think that just from a code readability point of >>> view makes worth it ? >> >> Taking a step back for perspective. >> >> I think there's broad consensus in moving the parameter to drm, naming >> the check function to drm_something_something(), and breaking the ties >> to CONFIG_VGA_CONSOLE. I appreciate the work you're doing to that >> effect. >> > > Thanks, I appreciate your feedback and comments. > >> I think everything beyond that is still a bit vague and/or >> contentious. So how about making the first 2-3 patches just that? >> Something we can all agree on, makes good progress, improves the kernel, >> and gives us something to build on? >> > > That works for me. Thomas, do you agree with that approach ?Sure. I think that's more or less what I proposed in my reply to that mail. Best regards Thomas> > Best regards, >-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20211105/ab9dc6f6/attachment.sig>