CGEL
2021-Aug-21 02:11 UTC
[Nouveau] [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page()
From: Luo penghao <luo.penghao at zte.com.cn>
In order to keep the code style consistency of the whole file,
the 'ret' assignments should be deleted.
The clang_analyzer complains as follows:
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:317:8:warning:
Although the value storedto 'ret' is used in the enclosing expression,
the value is never actually read from 'ret'.
Reported-by: Zeal Robot <zealci at zte.com.cn>
Signed-off-by: Luo penghao <luo.penghao at zte.com.cn>
---
drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c
index c43b824..d9f8e11 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c
@@ -314,7 +314,7 @@ nvkm_uvmm_mthd_page(struct nvkm_uvmm *uvmm, void *argv, u32
argc)
page = uvmm->vmm->func->page;
for (nr = 0; page[nr].shift; nr++);
- if (!(ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false)))
{
+ if (!(nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) {
if ((index = args->v0.index) >= nr)
return -EINVAL;
type = page[index].type;
--
2.15.2
Karol Herbst
2021-Sep-28 11:14 UTC
[Nouveau] [PATCH linux-next] drm/nouveau/mmu: drop unneeded assignment in the nvkm_uvmm_mthd_page()
Reviewed-by: Karol Herbst <kherbst at redhat.com> On Sat, Aug 21, 2021 at 10:46 AM CGEL <cgel.zte at gmail.com> wrote:> > From: Luo penghao <luo.penghao at zte.com.cn> > > In order to keep the code style consistency of the whole file, > the 'ret' assignments should be deleted. > > The clang_analyzer complains as follows: > > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c:317:8:warning: > Although the value storedto 'ret' is used in the enclosing expression, > the value is never actually read from 'ret'. > > Reported-by: Zeal Robot <zealci at zte.com.cn> > Signed-off-by: Luo penghao <luo.penghao at zte.com.cn> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > index c43b824..d9f8e11 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/uvmm.c > @@ -314,7 +314,7 @@ nvkm_uvmm_mthd_page(struct nvkm_uvmm *uvmm, void *argv, u32 argc) > page = uvmm->vmm->func->page; > for (nr = 0; page[nr].shift; nr++); > > - if (!(ret = nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > + if (!(nvif_unpack(ret, &argv, &argc, args->v0, 0, 0, false))) { > if ((index = args->v0.index) >= nr) > return -EINVAL; > type = page[index].type; > -- > 2.15.2 > >