Nouveau - Aug 2021 - [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices

On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann <arnd at kernel.org>
wrote:
>
> On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst <kherbst at redhat.com>
wrote:
> >
> > playing around a little bit with this, I think the original
"select
> > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird
mix of
> > drivers selecting and others depending on it. We could of course
convert
> > everything over to depend, and break those cycling dependency issues
with
> > this.
> >
> > Anyway this change on top of my initial patch is enough to make
Kconfig
> > happy and has the advantage of not having to mess with the deps of
nouveau
> > too much.
>
> Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE
> option itself 'default FB || DRM' though, to ensure that defconfigs
> keep working.
>
okay cool. Will send out a proper updated patch series soonish.
>       Arnd
>

On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst <kherbst at redhat.com>
wrote:
>
> On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann <arnd at kernel.org>
wrote:
> >
> > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst <kherbst at
redhat.com> wrote:
> > >
> > > playing around a little bit with this, I think the original
"select
> > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this
weird mix of
> > > drivers selecting and others depending on it. We could of course
convert
> > > everything over to depend, and break those cycling dependency
issues with
> > > this.
> > >
> > > Anyway this change on top of my initial patch is enough to make
Kconfig
> > > happy and has the advantage of not having to mess with the deps
of nouveau
> > > too much.
> >
> > Looks good to me. We'd probably want to make the
BACKLIGHT_CLASS_DEVICE
> > option itself 'default FB || DRM' though, to ensure that
defconfigs
> > keep working.
> >
>
> okay cool. Will send out a proper updated patch series soonish.
>
mhh, actually that breaks drivers selecting FB_BACKLIGHT as now
BACKLIGHT_CLASS_DEVICE might be disabled :(

somehow it doesn't feel like worth the effort converting it all over
to depend.. dunno.

Atm I would just use "select" in nouveau and deal with the conversion
later once somebody gets annoyed enough or so...
> >       Arnd
> >