Thomas Zimmermann
2021-May-12 18:55 UTC
[Nouveau] [PATCH] drm/nouveau: Remove invalid reference to struct drm_device.pdev
The pdev field got removed from struct drm_device recently. Replace the invalid reference with an upcast from the struct's dev field. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au> Fixes: b347e04452ff ("drm: Remove pdev field from struct drm_device") Cc: Thomas Zimmermann <tzimmermann at suse.de> Cc: Maxime Ripard <maxime at cerno.tech> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> Cc: Maxime Ripard <mripard at kernel.org> Cc: David Airlie <airlied at linux.ie> Cc: Daniel Vetter <daniel at ffwll.ch> Cc: dri-devel at lists.freedesktop.org --- This patch should be merged through drm-misc-next. --- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 7f38788a6c2b..2a298c171d4d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -460,7 +460,8 @@ nouveau_connector_of_detect(struct drm_connector *connector) struct drm_device *dev = connector->dev; struct nouveau_connector *nv_connector = nouveau_connector(connector); struct nouveau_encoder *nv_encoder; - struct device_node *cn, *dn = pci_device_to_OF_node(dev->pdev); + struct pci_dev *pdev = to_pci_dev(dev->dev); + struct device_node *cn, *dn = pci_device_to_OF_node(pdev); if (!dn || !((nv_encoder = find_encoder(connector, DCB_OUTPUT_TMDS)) || -- 2.31.1
Dave Airlie
2021-May-12 19:28 UTC
[Nouveau] [PATCH] drm/nouveau: Remove invalid reference to struct drm_device.pdev
On Thu, 13 May 2021 at 04:55, Thomas Zimmermann <tzimmermann at suse.de> wrote:> > The pdev field got removed from struct drm_device recently. Replace > the invalid reference with an upcast from the struct's dev field. > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> > Reported-by: Stephen Rothwell <sfr at canb.auug.org.au> > Fixes: b347e04452ff ("drm: Remove pdev field from struct drm_device") > Cc: Thomas Zimmermann <tzimmermann at suse.de> > Cc: Maxime Ripard <maxime at cerno.tech> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> > Cc: Maxime Ripard <mripard at kernel.org> > Cc: David Airlie <airlied at linux.ie> > Cc: Daniel Vetter <daniel at ffwll.ch> > Cc: dri-devel at lists.freedesktop.orgReviewed-by: Dave Airlie <airlied at redhat.com>> --- > This patch should be merged through drm-misc-next.please land asap. Thanks, Dave.> --- > drivers/gpu/drm/nouveau/nouveau_connector.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 7f38788a6c2b..2a298c171d4d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -460,7 +460,8 @@ nouveau_connector_of_detect(struct drm_connector *connector) > struct drm_device *dev = connector->dev; > struct nouveau_connector *nv_connector = nouveau_connector(connector); > struct nouveau_encoder *nv_encoder; > - struct device_node *cn, *dn = pci_device_to_OF_node(dev->pdev); > + struct pci_dev *pdev = to_pci_dev(dev->dev); > + struct device_node *cn, *dn = pci_device_to_OF_node(pdev); > > if (!dn || > !((nv_encoder = find_encoder(connector, DCB_OUTPUT_TMDS)) || > -- > 2.31.1 >