Lyude Paul
2021-Mar-18 16:49 UTC
[Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library
On Thu, 2021-03-18 at 11:15 +0200, Petri Latvala wrote:> On Thu, Mar 18, 2021 at 09:06:29AM +0200, Martin Peres wrote: > > On 18/03/2021 00:38, Lyude wrote: > > > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-uapi/drm_fourcc.h > > > index a7bc058c..87c87485 100644 > > > --- a/include/drm-uapi/drm_fourcc.h > > > +++ b/include/drm-uapi/drm_fourcc.h > > > @@ -681,7 +681,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 > > > modifier) > > > ? } > > > ? /* > > > - * 16Bx2 Block Linear layout, used by Tegra K1 and later > > > + * 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1 and > > > later > > > > Maybe remove one of the "and"s? > > > > 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1+ > > drm_fourcc.h is copied from the kernel, no hand-editing in IGT.These additions are all copied from the drm_fourcc.h file in the kernel though, do you want me to just update the whole file instead?> >-- Sincerely, Lyude Paul (she/her) Software Engineer at Red Hat Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite!
Petri Latvala
2021-Mar-19 09:05 UTC
[Nouveau] [igt-dev] [PATCH i-g-t] lib: Introduce the igt_nouveau library
On Thu, Mar 18, 2021 at 12:49:13PM -0400, Lyude Paul wrote:> On Thu, 2021-03-18 at 11:15 +0200, Petri Latvala wrote: > > On Thu, Mar 18, 2021 at 09:06:29AM +0200, Martin Peres wrote: > > > On 18/03/2021 00:38, Lyude wrote: > > > > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-uapi/drm_fourcc.h > > > > index a7bc058c..87c87485 100644 > > > > --- a/include/drm-uapi/drm_fourcc.h > > > > +++ b/include/drm-uapi/drm_fourcc.h > > > > @@ -681,7 +681,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 > > > > modifier) > > > > ? } > > > > ? /* > > > > - * 16Bx2 Block Linear layout, used by Tegra K1 and later > > > > + * 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1 and > > > > later > > > > > > Maybe remove one of the "and"s? > > > > > > 16Bx2 Block Linear layout, used by desktop GPUs, and Tegra K1+ > > > > drm_fourcc.h is copied from the kernel, no hand-editing in IGT. > > These additions are all copied from the drm_fourcc.h file in the kernel though, > do you want me to just update the whole file instead?It was more of a response to Martin's suggestion that would need to go through the kernel. As for this patch to IGT, yes please, copy the file from the kernel as-is. As a separate commit, commit message stating which SHA in kernel it's from. -- Petri Latvala> > > > > > > -- > Sincerely, > Lyude Paul (she/her) > Software Engineer at Red Hat > > Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've > asked me a question, are waiting for a review/merge on a patch, etc. and I > haven't responded in a while, please feel free to send me another email to check > on my status. I don't bite! >