Uwe Sauter
2021-Mar-03 13:25 UTC
[Nouveau] [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Am 03.03.21 um 14:12 schrieb Ilia Mirkin:> On Wed, Mar 3, 2021 at 7:41 AM Alex Riesen <alexander.riesen at cetitec.com> wrote: >> >> Ilia Mirkin, Sat, Feb 27, 2021 22:26:57 +0100: >>> Can you try Alex's patch to modetest and confirm that you see issues >>> with modetest? If so, can you (and maybe Alex as well) try an older >>> kernel (I'm on 5.6) and see if modetest behaves well there. [The patch >>> in question was to expose 256x256 as the 'preferred' size, but support >>> for the larger cursors has been around for a while.] Alex - if you >>> have time, same question to you. >> >> Sorry that it took so long. I retestet with the same kernel as Uwe did >> (5.4.101) and my results are the same: modetest with 64 and 128 cursors looks >> good, 256 broken. Didn't test with X this time (this being my main office >> machine), but can do later if required. > > Thanks for confirming! No need to test X - that will work fine, since > we were reporting the smaller cursors on that kernel. > > So I think we have definitive evidence that at least all Kepler > doesn't do 256x256 (and it's not just some bug in the display macro > rework that got introduced). And unless I'm blind and don't see the > corruption, Pascal seems fine. Question remains for Maxwell1/2 GPUs. > Unless someone has immediate plans to test on those, I'd recommend > bumping the minimum for 256x256 being reported to Pascal, and doing > 128x128 for Kepler / Maxwell.The only older model I have access to would be a 6600GT (NV43). Don't know if this would have any significance? Uwe> Simon, Lyude -- thoughts? > > Cheers, > > -ilia >
Ilia Mirkin
2021-Mar-03 13:33 UTC
[Nouveau] [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
On Wed, Mar 3, 2021 at 8:25 AM Uwe Sauter <uwe.sauter.de at gmail.com> wrote:> > Am 03.03.21 um 14:12 schrieb Ilia Mirkin: > > On Wed, Mar 3, 2021 at 7:41 AM Alex Riesen <alexander.riesen at cetitec.com> wrote: > >> > >> Ilia Mirkin, Sat, Feb 27, 2021 22:26:57 +0100: > >>> Can you try Alex's patch to modetest and confirm that you see issues > >>> with modetest? If so, can you (and maybe Alex as well) try an older > >>> kernel (I'm on 5.6) and see if modetest behaves well there. [The patch > >>> in question was to expose 256x256 as the 'preferred' size, but support > >>> for the larger cursors has been around for a while.] Alex - if you > >>> have time, same question to you. > >> > >> Sorry that it took so long. I retestet with the same kernel as Uwe did > >> (5.4.101) and my results are the same: modetest with 64 and 128 cursors looks > >> good, 256 broken. Didn't test with X this time (this being my main office > >> machine), but can do later if required. > > > > Thanks for confirming! No need to test X - that will work fine, since > > we were reporting the smaller cursors on that kernel. > > > > So I think we have definitive evidence that at least all Kepler > > doesn't do 256x256 (and it's not just some bug in the display macro > > rework that got introduced). And unless I'm blind and don't see the > > corruption, Pascal seems fine. Question remains for Maxwell1/2 GPUs. > > Unless someone has immediate plans to test on those, I'd recommend > > bumping the minimum for 256x256 being reported to Pascal, and doing > > 128x128 for Kepler / Maxwell. > > The only older model I have access to would be a 6600GT (NV43). Don't know if this would have any > significance?Nope, we want newer :) Maxwell came after Kepler. GTX 750 for Maxwell 1, and GTX 9xx for Maxwell 2. (GM10x and GM20x). Cheers, -ilia