Ye Bin
2021-Jan-23 01:30 UTC
[Nouveau] [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init
Fix follow warning:
drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ?pdev? set but
not used [-Wunused-but-set-variable]
struct pci_dev *pdev;
^~~~
Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Ye Bin <yebin10 at huawei.com>
---
drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 7cc683b8dc7a..e8c445eb1100 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
{
struct nouveau_drm *drm = nouveau_drm(dev);
struct nvbios *bios = &drm->vbios;
- struct pci_dev *pdev;
int ret;
/* only relevant for PCI devices */
if (!dev_is_pci(dev->dev))
return 0;
- pdev = to_pci_dev(dev->dev);
if (!NVInitVBIOS(dev))
return -ENODEV;
--
2.25.4
Thomas Zimmermann
2021-Feb-03 08:20 UTC
[Nouveau] [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init
Applied to drm-misc-next. Thanks for the patch! Am 23.01.21 um 02:30 schrieb Ye Bin:> Fix follow warning: > drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ?pdev? set but not used [-Wunused-but-set-variable] > struct pci_dev *pdev; > ^~~~ > > Reported-by: Hulk Robot <hulkci at huawei.com> > Signed-off-by: Ye Bin <yebin10 at huawei.com> > --- > drivers/gpu/drm/nouveau/nouveau_bios.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c > index 7cc683b8dc7a..e8c445eb1100 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c > @@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev) > { > struct nouveau_drm *drm = nouveau_drm(dev); > struct nvbios *bios = &drm->vbios; > - struct pci_dev *pdev; > int ret; > > /* only relevant for PCI devices */ > if (!dev_is_pci(dev->dev)) > return 0; > - pdev = to_pci_dev(dev->dev); > > if (!NVInitVBIOS(dev)) > return -ENODEV; >-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Felix Imend?rffer -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20210203/8f38d949/attachment.sig>