Thomas Zimmermann
2020-Nov-09 10:32 UTC
[Nouveau] [PATCH 1/2] drm/msm: Use struct dma_buf_map in GEM vmap ops
Fixes a build failure with msm. This change was supposed to be part of commit 49a3f51dfeee ("drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends"), but msm was forgotten. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Fixes: 49a3f51dfeee ("drm/gem: Use struct dma_buf_map in GEM vmap ops and convert GEM backends") Cc: Thomas Zimmermann <tzimmermann at suse.de> Cc: Christian K?nig <christian.koenig at amd.com> Cc: David Airlie <airlied at linux.ie> Cc: Daniel Vetter <daniel at ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> Cc: Maxime Ripard <mripard at kernel.org> Cc: Dave Airlie <airlied at redhat.com> Cc: Lucas Stach <l.stach at pengutronix.de> Cc: Russell King <linux+etnaviv at armlinux.org.uk> Cc: Christian Gmeiner <christian.gmeiner at gmail.com> Cc: Qiang Yu <yuq825 at gmail.com> Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Rob Herring <robh at kernel.org> Cc: Tomeu Vizoso <tomeu.vizoso at collabora.com> Cc: Steven Price <steven.price at arm.com> Cc: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com> Cc: Gerd Hoffmann <kraxel at redhat.com> Cc: Alex Deucher <alexander.deucher at amd.com> Cc: "Christian K?nig" <christian.koenig at amd.com> Cc: Sandy Huang <hjc at rock-chips.com> Cc: "Heiko St?bner" <heiko at sntech.de> Cc: Hans de Goede <hdegoede at redhat.com> Cc: Sean Paul <sean at poorly.run> Cc: Eric Anholt <eric at anholt.net> Cc: Rodrigo Siqueira <rodrigosiqueiramelo at gmail.com> Cc: Melissa Wen <melissa.srw at gmail.com> Cc: Haneen Mohammed <hamohammed.sa at gmail.com> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko at epam.com> Cc: Sumit Semwal <sumit.semwal at linaro.org> Cc: Emil Velikov <emil.velikov at collabora.com> Cc: Luben Tuikov <luben.tuikov at amd.com> Cc: Marek Szyprowski <m.szyprowski at samsung.com> Cc: Arunpravin <apaneers at amd.com> Cc: Huang Rui <ray.huang at amd.com> Cc: Madhav Chauhan <madhav.chauhan at amd.com> Cc: Jason Gunthorpe <jgg at ziepe.ca> Cc: Sam Ravnborg <sam at ravnborg.org> Cc: Chris Wilson <chris at chris-wilson.co.uk> Cc: Qinglang Miao <miaoqinglang at huawei.com> Cc: dri-devel at lists.freedesktop.org Cc: etnaviv at lists.freedesktop.org Cc: lima at lists.freedesktop.org Cc: nouveau at lists.freedesktop.org Cc: virtualization at lists.linux-foundation.org Cc: spice-devel at lists.freedesktop.org Cc: amd-gfx at lists.freedesktop.org Cc: linux-arm-kernel at lists.infradead.org Cc: linux-rockchip at lists.infradead.org Cc: xen-devel at lists.xenproject.org --- drivers/gpu/drm/msm/msm_drv.h | 4 ++-- drivers/gpu/drm/msm/msm_gem_prime.c | 13 ++++++++++--- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index c45789f36e48..a6aef687bc6e 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm/msm_drv.h @@ -295,8 +295,8 @@ int msm_gem_dumb_create(struct drm_file *file, struct drm_device *dev, int msm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, uint32_t handle, uint64_t *offset); struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj); -void *msm_gem_prime_vmap(struct drm_gem_object *obj); -void msm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); +int msm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map); +void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map); int msm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma); struct drm_gem_object *msm_gem_prime_import_sg_table(struct drm_device *dev, struct dma_buf_attachment *attach, struct sg_table *sg); diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c index 515ef80816a0..9880348a4dc7 100644 --- a/drivers/gpu/drm/msm/msm_gem_prime.c +++ b/drivers/gpu/drm/msm/msm_gem_prime.c @@ -22,12 +22,19 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj) return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages); } -void *msm_gem_prime_vmap(struct drm_gem_object *obj) +int msm_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map) { - return msm_gem_get_vaddr(obj); + void *vaddr; + + vaddr = msm_gem_get_vaddr(obj); + if (IS_ERR(vaddr)) + return PTR_ERR(vaddr); + dma_buf_map_set_vaddr(map, vaddr); + + return 0; } -void msm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) +void msm_gem_prime_vunmap(struct drm_gem_object *obj, struct dma_buf_map *map) { msm_gem_put_vaddr(obj); } -- 2.29.2
Maybe Matching Threads
- [PATCH 2/2] drm/mediatek: Use struct dma_buf_map in GEM vmap ops
- [PATCH v2 08/21] drm/msm: Introduce GEM object funcs
- [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin
- [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin
- [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin