Nouveau - May 2019 - [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()

Convert to use hmm_range_fault().

Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
---
 drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 93ed43c..8d56bd6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -649,7 +649,7 @@ struct nouveau_svmm {
 		range.values = nouveau_svm_pfn_values;
 		range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
 again:
-		ret = hmm_vma_fault(&range, true);
+		ret = hmm_range_fault(&range, true);
 		if (ret == 0) {
 			mutex_lock(&svmm->mutex);
 			if (!hmm_vma_range_done(&range)) {
-- 
1.9.1

On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux at
gmail.com> wrote:
>
> Convert to use hmm_range_fault().
Any comment on this patch ?
>
> Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
> index 93ed43c..8d56bd6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> @@ -649,7 +649,7 @@ struct nouveau_svmm {
>                 range.values = nouveau_svm_pfn_values;
>                 range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
>  again:
> -               ret = hmm_vma_fault(&range, true);
> +               ret = hmm_range_fault(&range, true);
>                 if (ret == 0) {
>                         mutex_lock(&svmm->mutex);
>                         if (!hmm_vma_range_done(&range)) {
> --
> 1.9.1
>

Hi Jason,

On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux at
gmail.com> wrote:
>
> Convert to use hmm_range_fault().
>
> Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
Would you like to take it through your new hmm tree or do I
need to resend it ?
> ---
>  drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
> index 93ed43c..8d56bd6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> @@ -649,7 +649,7 @@ struct nouveau_svmm {
>                 range.values = nouveau_svm_pfn_values;
>                 range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
>  again:
> -               ret = hmm_vma_fault(&range, true);
> +               ret = hmm_range_fault(&range, true);
>                 if (ret == 0) {
>                         mutex_lock(&svmm->mutex);
>                         if (!hmm_vma_range_done(&range)) {
> --
> 1.9.1
>

On Sat, Jun 08, 2019 at 12:14:50AM +0530, Souptick Joarder
wrote:
> Hi Jason,
> 
> On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux at
gmail.com> wrote:
> >
> > Convert to use hmm_range_fault().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux at gmail.com>
> 
> Would you like to take it through your new hmm tree or do I
> need to resend it ?
This patch is wrong as the API is different between the two see what
is in hmm.h to see the differences between hmm_vma_fault() hmm_range_fault()
a simple rename break things.
> 
> > ---
> >  drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
> > index 93ed43c..8d56bd6 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> > @@ -649,7 +649,7 @@ struct nouveau_svmm {
> >                 range.values = nouveau_svm_pfn_values;
> >                 range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
> >  again:
> > -               ret = hmm_vma_fault(&range, true);
> > +               ret = hmm_range_fault(&range, true);
> >                 if (ret == 0) {
> >                         mutex_lock(&svmm->mutex);
> >                         if (!hmm_vma_range_done(&range)) {
> > --
> > 1.9.1
> >