Rhys Kidd
2019-Jan-21 00:20 UTC
[Nouveau] [PATCH xf86-video-nouveau] wfb: Fix missing init function decls behind FB_ACCESS_WRAPPER
Fixes warning with xserver 1.20 and gcc 8.2: nv_driver.c:1443:9: warning: implicit declaration of function ‘wfbScreenInit’; did you mean ‘fbScreenInit’? [-Wimplicit-function-declaration] ret = wfbScreenInit(pScreen, FBStart, pScrn->virtualX, ^~~~~~~~~~~~~ fbScreenInit (See xserver 706e6d9cd074da606016ed4ecff51e9c2a822087) Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> --- src/nv_include.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/nv_include.h b/src/nv_include.h index de55570..6fdeeab 100644 --- a/src/nv_include.h +++ b/src/nv_include.h @@ -38,6 +38,7 @@ #include "dixstruct.h" #include "scrnintstr.h" +#define FB_ACCESS_WRAPPER #include "fb.h" #include "xf86cmap.h" -- 2.19.1
Ilia Mirkin
2019-Jan-23 05:41 UTC
[Nouveau] [PATCH xf86-video-nouveau] wfb: Fix missing init function decls behind FB_ACCESS_WRAPPER
This causes nouveau_drv.so to not be loadable due to a missing wfbPictureInit. I'm not 100% sure what causes it -- it happens at runtime in the middle of probe, and I don't have wfb enabled. Either way, I'm going to revert this until we get a better idea of what's going on. On Sun, Jan 20, 2019 at 7:20 PM Rhys Kidd <rhyskidd at gmail.com> wrote:> > Fixes warning with xserver 1.20 and gcc 8.2: > > nv_driver.c:1443:9: warning: implicit declaration of function ‘wfbScreenInit’; did you mean ‘fbScreenInit’? [-Wimplicit-function-declaration] > ret = wfbScreenInit(pScreen, FBStart, pScrn->virtualX, > ^~~~~~~~~~~~~ > fbScreenInit > > (See xserver 706e6d9cd074da606016ed4ecff51e9c2a822087) > > Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> > --- > src/nv_include.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/nv_include.h b/src/nv_include.h > index de55570..6fdeeab 100644 > --- a/src/nv_include.h > +++ b/src/nv_include.h > @@ -38,6 +38,7 @@ > #include "dixstruct.h" > #include "scrnintstr.h" > > +#define FB_ACCESS_WRAPPER > #include "fb.h" > > #include "xf86cmap.h" > -- > 2.19.1 > > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau
Rhys Kidd
2019-Jan-23 17:22 UTC
[Nouveau] [PATCH xf86-video-nouveau] wfb: Fix missing init function decls behind FB_ACCESS_WRAPPER
On Wed, Jan 23, 2019 at 12:41 AM Ilia Mirkin <imirkin at alum.mit.edu> wrote:> This causes nouveau_drv.so to not be loadable due to a missing > wfbPictureInit. I'm not 100% sure what causes it -- it happens at > runtime in the middle of probe, and I don't have wfb enabled. Either > way, I'm going to revert this until we get a better idea of what's > going on. >OK to revert, this patch must be exposing something else that is going on with wrappedfb support on some setups.> On Sun, Jan 20, 2019 at 7:20 PM Rhys Kidd <rhyskidd at gmail.com> wrote: > > > > Fixes warning with xserver 1.20 and gcc 8.2: > > > > nv_driver.c:1443:9: warning: implicit declaration of function > ‘wfbScreenInit’; did you mean ‘fbScreenInit’? > [-Wimplicit-function-declaration] > > ret = wfbScreenInit(pScreen, FBStart, pScrn->virtualX, > > ^~~~~~~~~~~~~ > > fbScreenInit > > > > (See xserver 706e6d9cd074da606016ed4ecff51e9c2a822087) > > > > Signed-off-by: Rhys Kidd <rhyskidd at gmail.com> > > --- > > src/nv_include.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/nv_include.h b/src/nv_include.h > > index de55570..6fdeeab 100644 > > --- a/src/nv_include.h > > +++ b/src/nv_include.h > > @@ -38,6 +38,7 @@ > > #include "dixstruct.h" > > #include "scrnintstr.h" > > > > +#define FB_ACCESS_WRAPPER > > #include "fb.h" > > > > #include "xf86cmap.h" > > -- > > 2.19.1 > > > > _______________________________________________ > > Nouveau mailing list > > Nouveau at lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/nouveau >-------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20190123/cc38d75d/attachment.html>