Bartlomiej Zolnierkiewicz
2018-Sep-10 12:48 UTC
[Nouveau] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On 08/22/2018 10:54 AM, Daniel Vetter wrote:> This was only added for the drm's fbdev emulation support, so that it > would try harder to show the Oops. > > Unfortunately this never really worked reliably, and in practice ended > up pushing the real Oops off the screen due to plentyfull locking, > sleep-while-atomic and other issues. So we removed all that support > from the fbdev emulation a while back. Aside: We've also removed the > kgdb support, for similar reasons. > > Since it's such a small patch I figured I don't split this up into the > usual 3-phase removal. > > Cc: Ben Skeggs <bskeggs at redhat.com> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > Cc: Hans de Goede <hdegoede at redhat.com> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch> > Cc: Alexander Kapshuk <alexander.kapshuk at gmail.com> > Cc: Kees Cook <keescook at chromium.org> > Cc: Thierry Reding <treding at nvidia.com> > Cc: David Lechner <david at lechnology.com> > Cc: nouveau at lists.freedesktop.org > Cc: linux-fbdev at vger.kernel.org > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Bartlomiej Zolnierkiewicz
2018-Sep-11 08:47 UTC
[Nouveau] [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
On 09/11/2018 09:42 AM, Daniel Vetter wrote:> On Mon, Sep 10, 2018 at 02:48:43PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> On 08/22/2018 10:54 AM, Daniel Vetter wrote: >>> This was only added for the drm's fbdev emulation support, so that it >>> would try harder to show the Oops. >>> >>> Unfortunately this never really worked reliably, and in practice ended >>> up pushing the real Oops off the screen due to plentyfull locking, >>> sleep-while-atomic and other issues. So we removed all that support >>> from the fbdev emulation a while back. Aside: We've also removed the >>> kgdb support, for similar reasons. >>> >>> Since it's such a small patch I figured I don't split this up into the >>> usual 3-phase removal. >>> >>> Cc: Ben Skeggs <bskeggs at redhat.com> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com> >>> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> >>> Cc: Hans de Goede <hdegoede at redhat.com> >>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch> >>> Cc: Alexander Kapshuk <alexander.kapshuk at gmail.com> >>> Cc: Kees Cook <keescook at chromium.org> >>> Cc: Thierry Reding <treding at nvidia.com> >>> Cc: David Lechner <david at lechnology.com> >>> Cc: nouveau at lists.freedesktop.org >>> Cc: linux-fbdev at vger.kernel.org >>> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> >> >> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com> > > Ack for merging the entire series through drm-misc-next?Yes, thanks for taking care of this. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
Seemingly Similar Threads
- [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
- [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
- [PATCH 1/4] fbdev: Drop FBINFO_CAN_FORCE_OUTPUT flag
- [PATCH 26/26] drm/<drivers>: Don't set FBINFO_(FLAG_)DEFAULT
- [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup