Nouveau - Sep 2018 - [PATCH] drm/nouveau/bios/dp: make array vsoff static, shrinks object size

From: Colin Ian King <colin.king at canonical.com>

Don't populate the array vsoff on the stack but instead make it
static. Makes the object code smaller by 67 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
   5753	    112	      0	   5865	   16e9	.../nouveau/nvkm/subdev/bios/dp.o

After:
   text	   data	    bss	    dec	    hex	filename
   5622	    176	      0	   5798	   16a6	.../nouveau/nvkm/subdev/bios/dp.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
index 3133b28f849c..b099d1209be8 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
@@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8 pc,
u8 vs, u8 pe,
 	u16 data;
 
 	if (*ver >= 0x30) {
-		const u8 vsoff[] = { 0, 4, 7, 9 };
+		static const u8 vsoff[] = { 0, 4, 7, 9 };
 		idx = (pc * 10) + vsoff[vs] + pe;
 		if (*ver >= 0x40 && *ver <= 0x41 && *hdr >= 0x12)
 			idx += nvbios_rd08(bios, outp + 0x11) * 40;
-- 
2.17.1

ping?

On 04/09/2018 16:23, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Don't populate the array vsoff on the stack but instead make it
> static. Makes the object code smaller by 67 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    5753	    112	      0	   5865	   16e9	.../nouveau/nvkm/subdev/bios/dp.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    5622	    176	      0	   5798	   16a6	.../nouveau/nvkm/subdev/bios/dp.o
> 
> (gcc version 8.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> index 3133b28f849c..b099d1209be8 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> @@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16 outp, u8
pc, u8 vs, u8 pe,
>  	u16 data;
>  
>  	if (*ver >= 0x30) {
> -		const u8 vsoff[] = { 0, 4, 7, 9 };
> +		static const u8 vsoff[] = { 0, 4, 7, 9 };
>  		idx = (pc * 10) + vsoff[vs] + pe;
>  		if (*ver >= 0x40 && *ver <= 0x41 && *hdr >=
0x12)
>  			idx += nvbios_rd08(bios, outp + 0x11) * 40;
>

On Fri, Jan 25, 2019 at 3:26 AM Colin Ian King <colin.king at
canonical.com> wrote:
>
> ping?
I've pushed this, and the others you pinged about, to my tree.

Thank you,
Ben.
>
> On 04/09/2018 16:23, Colin King wrote:
> > From: Colin Ian King <colin.king at canonical.com>
> >
> > Don't populate the array vsoff on the stack but instead make it
> > static. Makes the object code smaller by 67 bytes:
> >
> > Before:
> >    text          data     bss     dec     hex filename
> >    5753           112       0    5865    16e9
.../nouveau/nvkm/subdev/bios/dp.o
> >
> > After:
> >    text          data     bss     dec     hex filename
> >    5622           176       0    5798    16a6
.../nouveau/nvkm/subdev/bios/dp.o
> >
> > (gcc version 8.2.0 x86_64)
> >
> > Signed-off-by: Colin Ian King <colin.king at canonical.com>
> > ---
> >  drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > index 3133b28f849c..b099d1209be8 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/dp.c
> > @@ -212,7 +212,7 @@ nvbios_dpcfg_match(struct nvkm_bios *bios, u16
outp, u8 pc, u8 vs, u8 pe,
> >       u16 data;
> >
> >       if (*ver >= 0x30) {
> > -             const u8 vsoff[] = { 0, 4, 7, 9 };
> > +             static const u8 vsoff[] = { 0, 4, 7, 9 };
> >               idx = (pc * 10) + vsoff[vs] + pe;
> >               if (*ver >= 0x40 && *ver <= 0x41
&& *hdr >= 0x12)
> >                       idx += nvbios_rd08(bios, outp + 0x11) * 40;
> >
>