Nouveau - May 2018 - [Bug 106577] New: broken rendering with nine and nouveau (GM107)

https://bugs.freedesktop.org/show_bug.cgi?id=106577

            Bug ID: 106577
           Summary: broken rendering with nine and nouveau (GM107)
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: roman.elshin at gmail.com
        QA Contact: nouveau at lists.freedesktop.org

it is regression, but is it nouveau bug?:
# bad: [4d6fab245eec3880e2a59424a579851f44857ce8] cso: don't track the
number
of sampler states bound
git bisect bad 4d6fab245eec3880e2a59424a579851f44857ce8
# good: [c8459846905bf7adfb6b5010a77aee9269228bdb] st/mesa: sink and simplify
texBaseFormat getting for sampler states
git bisect good c8459846905bf7adfb6b5010a77aee9269228bdb
# first bad commit: [4d6fab245eec3880e2a59424a579851f44857ce8] cso: don't
track
the number of sampler states bound

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180519/81508bd3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Yes, it's a known issue.

The gallium API usage was updated in the CSO to be incompatible with how
nouveau processes texture/sampler binding. Haven't gotten around to fixing
it
yet though.

There's no "no regressions" policy, so you end up with a broken
driver.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180519/520fc562/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #2 from Roman Elshin <roman.elshin at gmail.com> ---
Thanks for clarifying, it is sad, i was always thinking that such changes are
comunity decision.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180519/5d2b3b53/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

iive at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|medium                      |highest

--- Comment #3 from iive at yahoo.com ---
Here is a link to the Ixit Nine issue tracker of this bug:
https://github.com/iXit/Mesa-3D/issues/308

It also contains a workaround that you could use if you compile your own
Mesa3D.

I must also say I am very disappointed by Nouveau developers who have not fixed
this issue for over 3 months after the exact cause has been known and they have
been informed.

You might be angry that the API has been changed without telling you, but it is
your users that suffer from visual glitches because you can't find the time
to
adapt your code, or discuss and push another fix.

The software render has already been fixed.
Nouveau is the only buggy driver, at this moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180528/8df6defd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #4 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to iive from comment #3)
> I must also say I am very disappointed by Nouveau developers
[...]
> Nouveau is the only buggy driver, at this moment.
Patches welcome.

Apparently thus far no one has the time/concentration necessary to rewrite all
the texture/sampler handling in the driver, and, more importantly, ensure that
everything still works.

As always, my standard recommendation applies -- DON'T BUY NVIDIA!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180528/e1a2144c/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #5 from iive at yahoo.com ---
(In reply to Ilia Mirkin from comment #4)
> (In reply to iive from comment #3)
> > I must also say I am very disappointed by Nouveau developers
> [...]
> > Nouveau is the only buggy driver, at this moment.
> 
> Patches welcome.
Can't help with that, no working NVidia hardware around.
Not going to buy one either.
> Apparently thus far no one has the time/concentration necessary to rewrite
> all the texture/sampler handling in the driver, and, more importantly,
> ensure that everything still works.
Three months is plenty of time for this kind of bug. Also "rewrite" is
too
dramatic word for what has to be done, it's more of "refactoring";
and yes
indeed it could be tricky.
There is also the possibility of placing a single dirty hack in nouveau driver
that is similar to the workaround in the issue tracker.

I think that keeping things private only made things worse. People trusted you
that you would fix this, and you let them down.

What is even worse, the tone you are using here, kind of implies that you do
not intend to work on a fix.

I hope that you will prove me wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180529/30d0a39e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #6 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to iive from comment #5)
> What is even worse, the tone you are using here, kind of implies that you
do
> not intend to work on a fix.
I do intend to work on one, but my time is limited, and this sort of thing
requires a lot of concentration not to muck up completely. I've been
intending
since I heard about the issue, so you can see that my intent doesn't mean
much.

Sounds like my free-time open-source contributions don't live up to your
high
standards. Feel free to hire someone to work on this if you're desperate to
see
it fixed but can't do it yourself, or recruit people to contribute in their
free time. In case it's not clear, manpower is lacking.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180529/daff352a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

--- Comment #7 from iive at yahoo.com ---
(In reply to Ilia Mirkin from comment #6)
> (In reply to iive from comment #5)
> > What is even worse, the tone you are using here, kind of implies that
you do
> > not intend to work on a fix.
> 
> I do intend to work on one
Three months have passed since this bug has been open
and nothing has changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180821/a688f92f/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=106577

Roman Elshin <roman.elshin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Roman Elshin <roman.elshin at gmail.com> ---
Fixed in master by commit:
fc0139d28339f58bcbb4946fea7608ecdaff93e7
nv50,nvc0: Fix gallium nine regression regarding sampler bindings
Thanks a lot!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20181202/bab9dbf7/attachment.html>