Luc Van Oostenryck
2018-Apr-24 13:15 UTC
[Nouveau] [PATCH] drm/nouveau: fix mode_valid's return type
The method struct drm_connector_helper_funcs::mode_valid is defined as returning an 'enum drm_mode_status' but the driver implementation for this method uses an 'int' for it. Fix this by using 'enum drm_mode_status' in the driver too. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 6ed9cb053..52b425cdf 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -1005,7 +1005,7 @@ get_tmds_link_bandwidth(struct drm_connector *connector, bool hdmi) return 112000; } -static int +static enum drm_mode_status nouveau_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { -- 2.17.0
Apparently Analagous Threads
- [PATCH] drm/virtio: fix mode_valid's return type
- [PATCH 4/4] drm/nouveau/kms/nv50-: Share DP SST mode_valid() handling with MST
- [PATCH v2 1/2] drm/nouveau/kms/nv50-: Get rid of bogus nouveau_conn_mode_valid()
- [PATCH RFC] drm: Add update_native_mode callback to connectors
- [PATCH] drm/nouveau: fix nouveau_dsm_get_client_id()'s return type