Nouveau - Jul 2017 - [PATCH xf86-video-amdgpu] Adapt to PixmapDirtyUpdateRec::src being a DrawablePtr

On 13/07/17 09:31 PM, Ilia Mirkin wrote:
> On Thu, Jul 13, 2017 at 4:27 AM, Michel Dänzer <michel at
daenzer.net> wrote:
>> On 18/04/17 07:07 PM, Michel Dänzer wrote:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>>> ---
>>>
>>> Chris / Ilia / Ben, this should be manageable for the intel/nouveau
>>> drivers, right?
>>
>> Any feedback, guys?
>>
>> I want to push the xserver change soon-ish. I could probably come up
>> with a corresponding patch for nouveau in the worst case, but I'm
afraid
>> not for intel.
> 
> Sorry, I'm not 1000% clear on what this patch is doing.
100% should suffice. ;)
> Is it literally just a type change from A to B and so code has to be fixed
> up for the new API?
That's basically it, corresponding to
https://patchwork.freedesktop.org/patch/150938/ .


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

On Thu, Jul 13, 2017 at 10:14 PM, Michel Dänzer <michel at daenzer.net>
wrote:
> On 13/07/17 09:31 PM, Ilia Mirkin wrote:
>> On Thu, Jul 13, 2017 at 4:27 AM, Michel Dänzer <michel at
daenzer.net> wrote:
>>> On 18/04/17 07:07 PM, Michel Dänzer wrote:
>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>>
>>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>>>> ---
>>>>
>>>> Chris / Ilia / Ben, this should be manageable for the
intel/nouveau
>>>> drivers, right?
>>>
>>> Any feedback, guys?
>>>
>>> I want to push the xserver change soon-ish. I could probably come
up
>>> with a corresponding patch for nouveau in the worst case, but
I'm afraid
>>> not for intel.
>>
>> Sorry, I'm not 1000% clear on what this patch is doing.
>
> 100% should suffice. ;)
>
>> Is it literally just a type change from A to B and so code has to be
fixed
>> up for the new API?
>
> That's basically it, corresponding to
> https://patchwork.freedesktop.org/patch/150938/ .
>From a brief glance at nouveau, it never uses PixmapDirtyUpdate,
except in src/nv_driver.c where I don't think the code would need to
be updated.

https://cgit.freedesktop.org/nouveau/xf86-video-nouveau/tree/src/nv_driver.c#n552

Let me know if you think I'm off.

  -ilia

On 14/07/17 11:24 AM, Ilia Mirkin wrote:
> On Thu, Jul 13, 2017 at 10:14 PM, Michel Dänzer <michel at
daenzer.net> wrote:
>> On 13/07/17 09:31 PM, Ilia Mirkin wrote:
>>> On Thu, Jul 13, 2017 at 4:27 AM, Michel Dänzer <michel at
daenzer.net> wrote:
>>>> On 18/04/17 07:07 PM, Michel Dänzer wrote:
>>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>>>
>>>>> Signed-off-by: Michel Dänzer <michel.daenzer at
amd.com>
>>>>> ---
>>>>>
>>>>> Chris / Ilia / Ben, this should be manageable for the
intel/nouveau
>>>>> drivers, right?
>>>>
>>>> Any feedback, guys?
>>>>
>>>> I want to push the xserver change soon-ish. I could probably
come up
>>>> with a corresponding patch for nouveau in the worst case, but
I'm afraid
>>>> not for intel.
>>>
>>> Sorry, I'm not 1000% clear on what this patch is doing.
>>
>> 100% should suffice. ;)
>>
>>> Is it literally just a type change from A to B and so code has to
be fixed
>>> up for the new API?
>>
>> That's basically it, corresponding to
>> https://patchwork.freedesktop.org/patch/150938/ .
> 
> From a brief glance at nouveau, it never uses PixmapDirtyUpdate,
> except in src/nv_driver.c where I don't think the code would need to
> be updated.
> 
>
https://cgit.freedesktop.org/nouveau/xf86-video-nouveau/tree/src/nv_driver.c#n552
There's also PixmapStart/StopDirtyTracking, though it looks like those
might happen to work as well at runtime, if you don't mind the compiler
warnings.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer