Nouveau - Apr 2017 - [PATCH v3 10/10] drm/nouveau: Enable stereoscopic 3D output over HDMI

Enable stereoscopic output for HDMI and DisplayPort connectors on
NV50+ (G80+) hardware.  We do not enable stereoscopy on older
hardware in case there is some older board that still has HDMI
output but for which we have no logic for setting the Vendor
InfoFrame.

With this, I get an obvious 3D output when using the "testdisplay"
program from intel-gpu-tools with the "-3" parameter and outputting
to a 3D-capable HDMI display, for all available 3D modes (be they
TB, SBSH, or FP) on all four G80+ DISPs.

Signed-off-by: Alastair Bridgewater <alastair.bridgewater at gmail.com>
---
 drivers/gpu/drm/nouveau/nouveau_connector.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c
b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 9a91e79..ff188c7 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -1324,6 +1324,13 @@ nouveau_connector_create(struct drm_device *dev, int
index)
 		break;
 	}
 
+	/* HDMI 3D support */
+	if ((disp->disp.oclass >= NV50_DISP)
+	    && ((type == DRM_MODE_CONNECTOR_DisplayPort)
+		|| (type == DRM_MODE_CONNECTOR_eDP)
+		|| (type == DRM_MODE_CONNECTOR_HDMIA)))
+		connector->stereo_allowed = true;
+
 	/* defaults, will get overridden in detect() */
 	connector->interlace_allowed = false;
 	connector->doublescan_allowed = false;
-- 
2.10.2

On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
<alastair.bridgewater at gmail.com> wrote:
> Enable stereoscopic output for HDMI and DisplayPort connectors on
> NV50+ (G80+) hardware.  We do not enable stereoscopy on older
> hardware in case there is some older board that still has HDMI
> output but for which we have no logic for setting the Vendor
> InfoFrame.
>
> With this, I get an obvious 3D output when using the
"testdisplay"
> program from intel-gpu-tools with the "-3" parameter and
outputting
> to a 3D-capable HDMI display, for all available 3D modes (be they
> TB, SBSH, or FP) on all four G80+ DISPs.
>
> Signed-off-by: Alastair Bridgewater <alastair.bridgewater at
gmail.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c
b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 9a91e79..ff188c7 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1324,6 +1324,13 @@ nouveau_connector_create(struct drm_device *dev, int
index)
>                 break;
>         }
>
> +       /* HDMI 3D support */
> +       if ((disp->disp.oclass >= NV50_DISP)
You probably meant G82_DISP. Although I don't know if there were any
G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
newer), so ... :)
> +           && ((type == DRM_MODE_CONNECTOR_DisplayPort)
> +               || (type == DRM_MODE_CONNECTOR_eDP)
> +               || (type == DRM_MODE_CONNECTOR_HDMIA)))
> +               connector->stereo_allowed = true;
> +
>         /* defaults, will get overridden in detect() */
>         connector->interlace_allowed = false;
>         connector->doublescan_allowed = false;
> --
> 2.10.2
>
> _______________________________________________
> Nouveau mailing list
> Nouveau at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

On Tue, Apr 11, 2017 at 1:32 PM, Ilia Mirkin <imirkin at alum.mit.edu>
wrote:
> On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
> <alastair.bridgewater at gmail.com> wrote:
> > +       /* HDMI 3D support */
> > +       if ((disp->disp.oclass >= NV50_DISP)
>
> You probably meant G82_DISP. Although I don't know if there were any
> G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
> newer), so ... :)
>
Having taken a closer look at the lower level code, I agree. It should be
G82_DISP.  Will correct in the v4 patch series (if there ends up being a v4
patch series). Good catch, and thank you!

-- Alastair Bridgewater
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170412/b3b3bcc6/attachment.html>