Hans de Goede
2016-Nov-09 17:15 UTC
[Nouveau] [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h
acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to
acpi_notifier_call_chain(). Move these defines to acpi/video.h so
that acpi_notifier listeners can check the type code using these
defines.
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
drivers/acpi/acpi_video.c | 11 -----------
include/acpi/video.h | 11 +++++++++++
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index c5557d0..201292e 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -43,17 +43,6 @@
#define ACPI_VIDEO_BUS_NAME "Video Bus"
#define ACPI_VIDEO_DEVICE_NAME "Video Device"
-#define ACPI_VIDEO_NOTIFY_SWITCH 0x80
-#define ACPI_VIDEO_NOTIFY_PROBE 0x81
-#define ACPI_VIDEO_NOTIFY_CYCLE 0x82
-#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83
-#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84
-
-#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85
-#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86
-#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87
-#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88
-#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89
#define MAX_NAME_LEN 20
diff --git a/include/acpi/video.h b/include/acpi/video.h
index 4536bd3..bfe484d 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -30,6 +30,17 @@ struct acpi_device;
#define ACPI_VIDEO_DISPLAY_LEGACY_PANEL 0x0110
#define ACPI_VIDEO_DISPLAY_LEGACY_TV 0x0200
+#define ACPI_VIDEO_NOTIFY_SWITCH 0x80
+#define ACPI_VIDEO_NOTIFY_PROBE 0x81
+#define ACPI_VIDEO_NOTIFY_CYCLE 0x82
+#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83
+#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84
+#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85
+#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86
+#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87
+#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88
+#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89
+
enum acpi_backlight_type {
acpi_backlight_undef = -1,
acpi_backlight_none = 0,
--
2.9.3
Peter Wu
2016-Nov-10 10:11 UTC
[Nouveau] [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h
On Wed, Nov 09, 2016 at 06:15:56PM +0100, Hans de Goede wrote:> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to > acpi_notifier_call_chain(). Move these defines to acpi/video.h so > that acpi_notifier listeners can check the type code using these > defines. > > Signed-off-by: Hans de Goede <hdegoede at redhat.com>Reviewed-by: Peter Wu <peter at lekensteyn.nl>> --- > drivers/acpi/acpi_video.c | 11 ----------- > include/acpi/video.h | 11 +++++++++++ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c > index c5557d0..201292e 100644 > --- a/drivers/acpi/acpi_video.c > +++ b/drivers/acpi/acpi_video.c > @@ -43,17 +43,6 @@ > > #define ACPI_VIDEO_BUS_NAME "Video Bus" > #define ACPI_VIDEO_DEVICE_NAME "Video Device" > -#define ACPI_VIDEO_NOTIFY_SWITCH 0x80 > -#define ACPI_VIDEO_NOTIFY_PROBE 0x81 > -#define ACPI_VIDEO_NOTIFY_CYCLE 0x82 > -#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83 > -#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84 > - > -#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85 > -#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86 > -#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87 > -#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88 > -#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89 > > #define MAX_NAME_LEN 20 > > diff --git a/include/acpi/video.h b/include/acpi/video.h > index 4536bd3..bfe484d 100644 > --- a/include/acpi/video.h > +++ b/include/acpi/video.h > @@ -30,6 +30,17 @@ struct acpi_device; > #define ACPI_VIDEO_DISPLAY_LEGACY_PANEL 0x0110 > #define ACPI_VIDEO_DISPLAY_LEGACY_TV 0x0200 > > +#define ACPI_VIDEO_NOTIFY_SWITCH 0x80 > +#define ACPI_VIDEO_NOTIFY_PROBE 0x81 > +#define ACPI_VIDEO_NOTIFY_CYCLE 0x82 > +#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83 > +#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84 > +#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85 > +#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86 > +#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87 > +#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88 > +#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89 > + > enum acpi_backlight_type { > acpi_backlight_undef = -1, > acpi_backlight_none = 0, > -- > 2.9.3 >
Rafael J. Wysocki
2016-Nov-24 01:26 UTC
[Nouveau] [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h
On Wednesday, November 09, 2016 06:15:56 PM Hans de Goede wrote:> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to > acpi_notifier_call_chain(). Move these defines to acpi/video.h so > that acpi_notifier listeners can check the type code using these > defines. > > Signed-off-by: Hans de Goede <hdegoede at redhat.com>I've applied this one, but I'd like to get an ACK from the DRM folks on the second one. Thanks, Rafael
Ben Skeggs
2016-Nov-24 01:30 UTC
[Nouveau] [PATCH] acpi: video: Move ACPI_VIDEO_NOTIFY_* defines to acpi/video.h
On 11/24/2016 11:27 AM, Rafael J. Wysocki wrote:> On Wednesday, November 09, 2016 06:15:56 PM Hans de Goede wrote: >> acpi_video.c passed the ACPI_VIDEO_NOTIFY_* defines as type code to >> acpi_notifier_call_chain(). Move these defines to acpi/video.h so >> that acpi_notifier listeners can check the type code using these >> defines. >> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com> > > I've applied this one, but I'd like to get an ACK from the DRM folks on > the second one.I've already taken the Nouveau patch through my tree. Ben.> > Thanks, > Rafael >-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: OpenPGP digital signature URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20161124/181c64f2/attachment.sig>