Ilia Mirkin
2015-Oct-10 19:58 UTC
[Nouveau] [PATCH] nv50, nvc0: don't base decisions on available pushbuf space
On Sat, Oct 10, 2015 at 3:55 PM, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:> > > On 10/10/2015 09:42 PM, Ilia Mirkin wrote: >> >> On Sat, Oct 10, 2015 at 3:41 PM, Samuel Pitoiset >> <samuel.pitoiset at gmail.com> wrote: >>> >>> This patch looks fine except that it should be a bit more normalized. I >>> mean, sometimes you break when PUSH_SPACE fails, sometimes not. Same for >>> PUSH_SPACE calls, sometimes you add it sometimes not. >> >> Meh. We need to get our error checking situation straight, but this >> isn't the patch to do it in. > > > Yeah, but this needs to be clarified.What does?
Ilia Mirkin
2015-Oct-10 20:17 UTC
[Nouveau] [PATCH] nv50, nvc0: don't base decisions on available pushbuf space
On Sat, Oct 10, 2015 at 4:21 PM, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:> > > On 10/10/2015 09:58 PM, Ilia Mirkin wrote: >> >> On Sat, Oct 10, 2015 at 3:55 PM, Samuel Pitoiset >> <samuel.pitoiset at gmail.com> wrote: >>> >>> >>> On 10/10/2015 09:42 PM, Ilia Mirkin wrote: >>>> >>>> On Sat, Oct 10, 2015 at 3:41 PM, Samuel Pitoiset >>>> <samuel.pitoiset at gmail.com> wrote: >>>>> >>>>> This patch looks fine except that it should be a bit more normalized. I >>>>> mean, sometimes you break when PUSH_SPACE fails, sometimes not. Same >>>>> for >>>>> PUSH_SPACE calls, sometimes you add it sometimes not. >>>> >>>> Meh. We need to get our error checking situation straight, but this >>>> isn't the patch to do it in. >>> >>> >>> Yeah, but this needs to be clarified. >> >> What does? > > > I mean, we should either use PUSH_SPACE everywhere or not at all, and always > breaks (or not) when PUSH_SPACE fails. > That's really a minor issue.It's actually a major issue. Error-handling is practically non-existent. There are a couple of spots here and there, but it doesn't really scale up. I guess I (semi-)accidentally removed a couple of spots that error checked, but, again, meh. Doing this for real will require some careful thought. -ilia
Samuel Pitoiset
2015-Oct-10 20:21 UTC
[Nouveau] [PATCH] nv50, nvc0: don't base decisions on available pushbuf space
On 10/10/2015 09:58 PM, Ilia Mirkin wrote:> On Sat, Oct 10, 2015 at 3:55 PM, Samuel Pitoiset > <samuel.pitoiset at gmail.com> wrote: >> >> On 10/10/2015 09:42 PM, Ilia Mirkin wrote: >>> On Sat, Oct 10, 2015 at 3:41 PM, Samuel Pitoiset >>> <samuel.pitoiset at gmail.com> wrote: >>>> This patch looks fine except that it should be a bit more normalized. I >>>> mean, sometimes you break when PUSH_SPACE fails, sometimes not. Same for >>>> PUSH_SPACE calls, sometimes you add it sometimes not. >>> Meh. We need to get our error checking situation straight, but this >>> isn't the patch to do it in. >> >> Yeah, but this needs to be clarified. > What does?I mean, we should either use PUSH_SPACE everywhere or not at all, and always breaks (or not) when PUSH_SPACE fails. That's really a minor issue.