Nouveau - Oct 2015 - [Bug 92377] New: Add support for early voltage table as seen on nv43

https://bugs.freedesktop.org/show_bug.cgi?id=92377

            Bug ID: 92377
           Summary: Add support for early voltage table as seen on nv43
           Product: xorg
           Version: git
          Hardware: x86 (IA32)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: randrik at mail.ru
        QA Contact: xorg-team at lists.x.org

Created attachment 118791
  --> https://bugs.freedesktop.org/attachment.cgi?id=118791&action=edit
vbios as extracted by envytools

Latest nouveau (after 4.2) started to refuse to change clocks on my nv43 board.
Investigation showed it was simply failing to find voltage table, while such
table was recognized by nvbios tool from envytools.

So, I've added patch along those lines:



    diff --git a/drm/nouveau/nvkm/subdev/bios/volt.c
b/drm/nouveau/nvkm/subdev/bios/volt.c
    index 6e0a336..3e9dafa 100644
    --- a/drm/nouveau/nvkm/subdev/bios/volt.c
    +++ b/drm/nouveau/nvkm/subdev/bios/volt.c
    @@ -40,8 +40,10 @@ nvbios_volt_table(struct nvkm_bios *bios, u8 *ver, u8
*hdr, u8 *cnt, u8 *len)

                    if (volt) {
                            *ver = nvbios_rd08(bios, volt + 0);
    +                       printk ("nvbios_volt_table_Ver, %d\n",
*ver);
                            switch (*ver) {
                            case 0x12:
    +                       case 0x10:
                                    *hdr = 5;
                                    *cnt = nvbios_rd08(bios, volt + 2);
                                    *len = nvbios_rd08(bios, volt + 1);
    @@ -71,8 +73,11 @@ nvbios_volt_parse(struct nvkm_bios *bios, u8 *ver, u8
*hdr, u8 *cnt, u8 *len,
     {
            u16 volt = nvbios_volt_table(bios, ver, hdr, cnt, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_parse called!\n");
    +       printk("volt_table_Version: %d\n", !!volt * *ver);
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
                    info->type    = NVBIOS_VOLT_GPIO;
                    info->vidmask = nvbios_rd08(bios, volt + 0x04);
                    break;
    @@ -131,8 +136,10 @@ nvbios_volt_entry_parse(struct nvkm_bios *bios, int
idx, u8 *ver, u8 *len,
     {
            u16 volt = nvbios_volt_entry(bios, idx, ver, len);
            memset(info, 0x00, sizeof(*info));
    +       printk("nvbios_volt_entry_parse called!\n");
            switch (!!volt * *ver) {
            case 0x12:
    +       case 0x10:
            case 0x20:
                    info->voltage = nvbios_rd08(bios, volt + 0x00) * 10000;
                    info->vid     = nvbios_rd08(bios, volt + 0x01);


and it seems to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20151010/165b9614/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=92377

Andrew Randrianasulu <randrik at mail.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118791|0                           |1
        is obsolete|                            |

--- Comment #1 from Andrew Randrianasulu <randrik at mail.ru> ---
Created attachment 118792
  --> https://bugs.freedesktop.org/attachment.cgi?id=118792&action=edit
vbios  as extracted by envytools, try 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20151010/795c1553/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=92377

Martin Peres <martin.peres at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #2 from Martin Peres <martin.peres at free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/issues/223.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20191204/9c2d2294/attachment.html>