Nouveau - Sep 2015 - [Bug 91890] New: [nve7] witcher2: blurry image & DATA_ERRORs (class 0xa097 mthd 0x2380/0x238c)

https://bugs.freedesktop.org/show_bug.cgi?id=91890

            Bug ID: 91890
           Summary: [nve7] witcher2: blurry image & DATA_ERRORs (class
                    0xa097 mthd 0x2380/0x238c)
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: marcin.slusarz at gmail.com
        QA Contact: nouveau at lists.freedesktop.org

Created attachment 118091
  --> https://bugs.freedesktop.org/attachment.cgi?id=118091&action=edit
Witcher2 on Nouveau

Witcher 2 looks blurry on nouveau and spams dmesg with a lot of:

[  390.489069] nouveau E[  PGRAPH][0000:01:00.0] DATA_ERROR [INVALID_BITFIELD]
ch 5 [0x007f853000 witcher2[5663]] subc 0 class 0xa097 mthd 0x2380 data
0x00024000
[  390.489156] nouveau E[  PGRAPH][0000:01:00.0] DATA_ERROR [INVALID_BITFIELD]
ch 5 [0x007f853000 witcher2[5663]] subc 0 class 0xa097 mthd 0x238c data
0x00010500

Screenshots comparing intel and nouveau attached.
Apitrace: http://people.freedesktop.org/~mslusarz/witcher2.trace.xz (130MB)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150905/1a50ef63/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

Marcin Slusarz <marcin.slusarz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118091|text/plain                  |image/png
          mime type|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150905/8d3ecf5b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

--- Comment #1 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
Created attachment 118092
  --> https://bugs.freedesktop.org/attachment.cgi?id=118092&action=edit
Witcher2 on Intel

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150905/f9974fd0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

--- Comment #2 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Hmmm... that's the CB_SIZE which is 64K max, aka 0x10000. Somehow it's
trying
to write to 0x24000 which is well past that. Should probably throw some asserts
in to see where it's happening.

IIRC I fixed some issues with CB writes at some point, can you confirm that
this happens on a semi-recent mesa? Preferably Mesa 11-rcN or git?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150905/660098e5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

--- Comment #3 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
This happens on mesa git (3c6c4d4f298ec81fe57992790a68aaab2e573519).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150905/d75aaab3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

--- Comment #4 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Created attachment 118094
  --> https://bugs.freedesktop.org/attachment.cgi?id=118094&action=edit
cb management patch

This is a very preliminary patch, but in replaying the above trace, I get the
same results as on intel (at least on the last frame). And at least with mesa
10.6.3, I do see the same blurriness as you did. (Fun, looks like it makes use
of GL_DEPTH_BOUNDS_TEST_EXT, which wasn't available in 10.6.3.)

Please confirm that the included patch fixes the blurriness. It's a
pile-o-hacks right now, but could definitely be cleaned up. I've been aware
of
this issue for a while, but didn't have a reason to fix until now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150906/2debda38/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

--- Comment #5 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
This patch resolves both blurriness and DATA_ERRORs. 
Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150906/d9b3bacd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91890

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Pushed out this commit:

commit e50c01d5af305e07110cb4a38d5a655437058f04
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Wed Sep 9 03:17:38 2015 -0400

    nvc0: keep track of cb bindings per buffer, use for upload settings

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150910/31a7da50/attachment.html>