Samuel Pitoiset
2015-Aug-26 20:32 UTC
[Nouveau] [PATCH] core: remove unused variables detected by Clang
These variables have been left since the recent big merge.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
drm/nouveau/nvkm/engine/device/base.c | 4 ----
drm/nouveau/nvkm/engine/dma/base.c | 5 -----
drm/nouveau/nvkm/engine/sw/base.c | 5 -----
3 files changed, 14 deletions(-)
diff --git a/drm/nouveau/nvkm/engine/device/base.c
b/drm/nouveau/nvkm/engine/device/base.c
index 952a508..a32ac99 100644
--- a/drm/nouveau/nvkm/engine/device/base.c
+++ b/drm/nouveau/nvkm/engine/device/base.c
@@ -2291,10 +2291,6 @@ nvkm_device_del(struct nvkm_device **pdevice)
}
}
-static const struct nvkm_engine_func
-nvkm_device_func = {
-};
-
int
nvkm_device_ctor(const struct nvkm_device_func *func,
const struct nvkm_device_quirk *quirk,
diff --git a/drm/nouveau/nvkm/engine/dma/base.c
b/drm/nouveau/nvkm/engine/dma/base.c
index c1957ce..9769fc0 100644
--- a/drm/nouveau/nvkm/engine/dma/base.c
+++ b/drm/nouveau/nvkm/engine/dma/base.c
@@ -97,11 +97,6 @@ nvkm_dma_oclass_fifo_new(const struct nvkm_oclass *oclass,
void *data, u32 size,
}
static const struct nvkm_sclass
-nvkm_dma_oclass_fifo = {
- .ctor = nvkm_dma_oclass_fifo_new,
-};
-
-static const struct nvkm_sclass
nvkm_dma_sclass[] = {
{ 0, 0, NV_DMA_FROM_MEMORY, NULL, nvkm_dma_oclass_fifo_new },
{ 0, 0, NV_DMA_TO_MEMORY, NULL, nvkm_dma_oclass_fifo_new },
diff --git a/drm/nouveau/nvkm/engine/sw/base.c
b/drm/nouveau/nvkm/engine/sw/base.c
index d46f229..53c1f7e 100644
--- a/drm/nouveau/nvkm/engine/sw/base.c
+++ b/drm/nouveau/nvkm/engine/sw/base.c
@@ -55,11 +55,6 @@ nvkm_sw_oclass_new(const struct nvkm_oclass *oclass, void
*data, u32 size,
return sclass->ctor(chan, oclass, data, size, pobject);
}
-static const struct nvkm_sclass
-nvkm_sw_oclass = {
- .ctor = nvkm_sw_oclass_new,
-};
-
static int
nvkm_sw_oclass_get(struct nvkm_oclass *oclass, int index)
{
--
2.5.0
Ben Skeggs
2015-Aug-27 04:59 UTC
[Nouveau] [PATCH] core: remove unused variables detected by Clang
On 27 August 2015 at 06:32, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:> These variables have been left since the recent big merge.Hey Samuel, These were mostly bits and pieces left over from an older revision of the rework, I've squashed the bits back into the commits that caused them. Thanks, Ben.> > Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com> > --- > drm/nouveau/nvkm/engine/device/base.c | 4 ---- > drm/nouveau/nvkm/engine/dma/base.c | 5 ----- > drm/nouveau/nvkm/engine/sw/base.c | 5 ----- > 3 files changed, 14 deletions(-) > > diff --git a/drm/nouveau/nvkm/engine/device/base.c b/drm/nouveau/nvkm/engine/device/base.c > index 952a508..a32ac99 100644 > --- a/drm/nouveau/nvkm/engine/device/base.c > +++ b/drm/nouveau/nvkm/engine/device/base.c > @@ -2291,10 +2291,6 @@ nvkm_device_del(struct nvkm_device **pdevice) > } > } > > -static const struct nvkm_engine_func > -nvkm_device_func = { > -}; > - > int > nvkm_device_ctor(const struct nvkm_device_func *func, > const struct nvkm_device_quirk *quirk, > diff --git a/drm/nouveau/nvkm/engine/dma/base.c b/drm/nouveau/nvkm/engine/dma/base.c > index c1957ce..9769fc0 100644 > --- a/drm/nouveau/nvkm/engine/dma/base.c > +++ b/drm/nouveau/nvkm/engine/dma/base.c > @@ -97,11 +97,6 @@ nvkm_dma_oclass_fifo_new(const struct nvkm_oclass *oclass, void *data, u32 size, > } > > static const struct nvkm_sclass > -nvkm_dma_oclass_fifo = { > - .ctor = nvkm_dma_oclass_fifo_new, > -}; > - > -static const struct nvkm_sclass > nvkm_dma_sclass[] = { > { 0, 0, NV_DMA_FROM_MEMORY, NULL, nvkm_dma_oclass_fifo_new }, > { 0, 0, NV_DMA_TO_MEMORY, NULL, nvkm_dma_oclass_fifo_new }, > diff --git a/drm/nouveau/nvkm/engine/sw/base.c b/drm/nouveau/nvkm/engine/sw/base.c > index d46f229..53c1f7e 100644 > --- a/drm/nouveau/nvkm/engine/sw/base.c > +++ b/drm/nouveau/nvkm/engine/sw/base.c > @@ -55,11 +55,6 @@ nvkm_sw_oclass_new(const struct nvkm_oclass *oclass, void *data, u32 size, > return sclass->ctor(chan, oclass, data, size, pobject); > } > > -static const struct nvkm_sclass > -nvkm_sw_oclass = { > - .ctor = nvkm_sw_oclass_new, > -}; > - > static int > nvkm_sw_oclass_get(struct nvkm_oclass *oclass, int index) > { > -- > 2.5.0 > > _______________________________________________ > Nouveau mailing list > Nouveau at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau