Nouveau - Jul 2015 - [PATCH 1/2] nouveau/compiler: fix trivial compiler warnings

On 8 July 2015 at 20:34, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> Mh i'm not aware of me ever changed the "nouveau_compiler".
But i'm happy to
> see this made you laugh, so it has something positive at least... :/
>
Story time:
This particular compiler warning has been brought up (incl here) four
or five times. Each time, Ilia feels reluctant about the fix as the
(gcc) compiler gets it wrong.

Personally I do not see a problem with explicitly initialising the
variable at this instance, yet I'm curious for how long Ilia will say
"no" to this (type of) patch(es) :-P

No offence, I just find it funny.
Emil

On 08.07.2015 21:42, Emil Velikov wrote:
> On 8 July 2015 at 20:34, Tobias Klausmann
> <tobias.johannes.klausmann at mni.thm.de> wrote:
>> Mh i'm not aware of me ever changed the
"nouveau_compiler". But i'm happy to
>> see this made you laugh, so it has something positive at least... :/
>>
> Story time:
> This particular compiler warning has been brought up (incl here) four
> or five times. Each time, Ilia feels reluctant about the fix as the
> (gcc) compiler gets it wrong.
>
> Personally I do not see a problem with explicitly initialising the
> variable at this instance, yet I'm curious for how long Ilia will say
> "no" to this (type of) patch(es) :-P
>
> No offence, I just find it funny.
> Emil
Oh i did even answer in a thread for a patch from Martin where he 
propose the same change (even with the same prefix :D). Ilia maybe you 
should take this after all, as it seems you are haunted by this :P

I don't mind telling people that the compiler is wrong :)

On Wed, Jul 8, 2015 at 3:53 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
>
>
> On 08.07.2015 21:42, Emil Velikov wrote:
>>
>> On 8 July 2015 at 20:34, Tobias Klausmann
>> <tobias.johannes.klausmann at mni.thm.de> wrote:
>>>
>>> Mh i'm not aware of me ever changed the
"nouveau_compiler". But i'm happy
>>> to
>>> see this made you laugh, so it has something positive at least...
:/
>>>
>> Story time:
>> This particular compiler warning has been brought up (incl here) four
>> or five times. Each time, Ilia feels reluctant about the fix as the
>> (gcc) compiler gets it wrong.
>>
>> Personally I do not see a problem with explicitly initialising the
>> variable at this instance, yet I'm curious for how long Ilia will
say
>> "no" to this (type of) patch(es) :-P
>>
>> No offence, I just find it funny.
>> Emil
>
> Oh i did even answer in a thread for a patch from Martin where he propose
> the same change (even with the same prefix :D). Ilia maybe you should take
> this after all, as it seems you are haunted by this :P