Nouveau - Jun 2015 - [Bug 91117] New: Nimbus (running in wine) has rendering issues, objects are semi-transparent

https://bugs.freedesktop.org/show_bug.cgi?id=91117

            Bug ID: 91117
           Summary: Nimbus (running in wine) has rendering issues, objects
                    are semi-transparent
           Product: Mesa
           Version: 10.5
          Hardware: Other
               URL: http://store.steampowered.com/app/50000/
                OS: All
            Status: NEW
          Keywords: bisected, regression
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: gyebro69 at gmail.com
        QA Contact: nouveau at lists.freedesktop.org
                CC: imirkin at alum.mit.edu

The game is available on Steam and needs Wine to run.
The main menu and all the objects in the game appear transparently, see this
screenshot for comparison (images on the right show the correct behaviour,
images on the left is the current state): http://imgur.com/aDhYehq

The problem doesn't occur with the binary Nvidia drivers (340.76).

Regression introduced by

commit 9e94b87b6012450d714edc6d0c46b15a89d5ce61
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Thu Jan 1 01:01:13 2015 -0500

    nv50/ir: fold MAD when one of the multiplicands is const

    Fold MAD dst, src0, immed, src2 (or src0/immed swapped) when
     - immed = 0 -> MOV dst, src2
     - immed = +/- 1 -> ADD dst, src0, src2

    These types of MAD patterns were observed in some st/nine shaders.

Reverting the commit on current git fixes the problem for me.

Trace file generated by apitrace:
https://drive.google.com/open?id=0B-tTbLKBl-tObmNTbmZLV08xMzA&authuser=0

To reproduce the problem in the demo version you need Wine (preferably the
latest development version) and a Steam account. The game needs native d3dx9_36
('winetricks d3dx9_36').

Fedora 22 32-bit
Mesa 10.6-branchpoint-676-g7de8569
VGA compatible controller: NVIDIA Corporation G92 [GeForce GTS 250] (rev a2)
(prog-if 00 [VGA controller])
Kernel 4.0.5-300.fc22.i686+PAE
xorg-x11-server-Xorg-1.17.2-1.fc22.i686

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150626/575ff845/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91117

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
The trace starts working when applying

http://patchwork.freedesktop.org/patch/53049/

Note that the bisected commit merely enables the code fixed by the above to
operate on the shaders in question rather than actually having a problem by
itself. The resulting code ended up as "b - a" instead of "a -
b".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150626/62387914/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=91117

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Fix pushed. If this trace still gives you issues, feel free to reopen.

commit ad62ec8316a926682958e7ab52639992867c3755
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Fri Jun 26 15:01:22 2015 -0400

    nv50/ir: propagate modifier to right arg when const-folding mad

    An immediate has to be the second arg of an ADD operation. However we
    were mistakenly propagating the modifier of the non-folded value to the
    folded immediate argument.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91117
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Cc: "10.5 10.6" <mesa-stable at lists.freedesktop.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150626/4fa88515/attachment.html>