Nouveau - Jun 2015 - [Bug 90888] New: A trivial fix for a potential crash

https://bugs.freedesktop.org/show_bug.cgi?id=90888

            Bug ID: 90888
           Summary: A trivial fix for a potential crash
           Product: Mesa
           Version: git
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: j-r at online.de
        QA Contact: nouveau at lists.freedesktop.org

Created attachment 116340
  --> https://bugs.freedesktop.org/attachment.cgi?id=116340&action=edit
Candidate patch

OP_JOIN are static casted to FlowInstruction, but handleTXL creates OP_JOIN
that is no FlowInstruction.

It probably doesn't matter outside debug builds, since only the IR printer
seems to access the additional FlowInstruction fields.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150607/b3710ce5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90888

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Great patch. Please mail it out to nouveau at lists.freedesktop.org, these
things
are usually just done over email when there's no real bug to keep track of.
One
small thing is I normally use "nv50/ir" prefix when modifying stuff in
codegen.

I'm away from computers where I can check this out for another week or so,
but
I'll be able to take a detailed look then. [And your other bug too.]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150607/43f24947/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=90888

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Hrmph.... one small difference is that mkOp() appears to set the instruction
with ->fixed = 1. I'm adding that in just in case it mattered in this
case...
Converter::insertConvergenceOps seems to do this too. Now pushed. In the
future, you can just mail patches to nouveau at lists.freedesktop.org and/or
mesa-dev at lists.freedesktop.org.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150615/73780868/attachment-0001.html>