Dave Airlie
2015-May-21 04:40 UTC
[Nouveau] [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()
On 21 May 2015 at 03:26, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:> > > On 05/20/2015 07:13 PM, Ilia Mirkin wrote: >> >> This is obviously a bug, but one that has been there for some time. >> Please figure out what this is guarding, and confirm that the feature >> continues to work. > > > Sure, but do you have any ideas how to test this part of the DDX ? > It's the first time I play with it... >It's fine, the code just avoids going into the name checks if the type isn't a enum, it won't break anything actually fixing it. The fix is Reviewed-by: Dave Airlie <airlied at redhat.com>
Samuel Pitoiset
2015-May-27 11:23 UTC
[Nouveau] [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()
On 05/21/2015 06:40 AM, Dave Airlie wrote:> On 21 May 2015 at 03:26, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote: >> >> On 05/20/2015 07:13 PM, Ilia Mirkin wrote: >>> This is obviously a bug, but one that has been there for some time. >>> Please figure out what this is guarding, and confirm that the feature >>> continues to work. >> >> Sure, but do you have any ideas how to test this part of the DDX ? >> It's the first time I play with it... >> > It's fine, the code just avoids going into the name checks if the type > isn't a enum, > it won't break anything actually fixing it. > > The fix is > > Reviewed-by: Dave Airlie <airlied at redhat.com>Okay, thanks Dave.
Samuel Pitoiset
2015-Jun-10 21:47 UTC
[Nouveau] [PATCH] fix a wrong use of a logical operator in drmmode_output_dpms()
Pushed. On 05/27/2015 01:23 PM, Samuel Pitoiset wrote:> > > On 05/21/2015 06:40 AM, Dave Airlie wrote: >> On 21 May 2015 at 03:26, Samuel Pitoiset <samuel.pitoiset at gmail.com> >> wrote: >>> >>> On 05/20/2015 07:13 PM, Ilia Mirkin wrote: >>>> This is obviously a bug, but one that has been there for some time. >>>> Please figure out what this is guarding, and confirm that the feature >>>> continues to work. >>> >>> Sure, but do you have any ideas how to test this part of the DDX ? >>> It's the first time I play with it... >>> >> It's fine, the code just avoids going into the name checks if the type >> isn't a enum, >> it won't break anything actually fixing it. >> >> The fix is >> >> Reviewed-by: Dave Airlie <airlied at redhat.com> > > Okay, thanks Dave.