Alexandre Courbot
2015-May-20 05:11 UTC
[Nouveau] [PATCH] nouveau: add coherent BO attribute
On Fri, May 15, 2015 at 8:39 PM, Maarten Lankhorst <maarten at mblankhorst.nl> wrote:> Op 15-05-15 om 09:11 schreef Alexandre Courbot: >> Re-pinging Marteen on an email address that still exists :P >> >> On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> wrote: >>> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >>>> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>>>> Hey, >>>>> >>>>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>>>> Add a flag allowing Nouveau to specify that an object should be coherent >>>>>> at allocation time. This is required for some class of objects like >>>>>> fences which are randomly-accessed by both the CPU and GPU. This flag >>>>>> instructs the kernel driver to make sure the object remains coherent >>>>>> even on architectures for which coherency is not guaranteed by the bus. >>>>>> >>>>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>>>> I don't see a problem with this patch, but similar patches to intel to >>>>> libdrm have been shot down when the changes weren't in an official kernel >>>>> yet, so I think this should wait until the change is at least in drm-next. >>>>> ;-) >>>> >>>> Sounds good. I will ping you again once the kernel change reaches -next. >>> Hi Marteen, >>> >>> The kernel change required for this patch is now in -next. Do you >>> think we can merge it now? > I think it would be ok to merge now.Great - who could do this? :P
On 20/05/15 08:11, Alexandre Courbot wrote:> On Fri, May 15, 2015 at 8:39 PM, Maarten Lankhorst > <maarten at mblankhorst.nl> wrote: >> Op 15-05-15 om 09:11 schreef Alexandre Courbot: >>> Re-pinging Marteen on an email address that still exists :P >>> >>> On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> wrote: >>>> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >>>>> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>>>>> Hey, >>>>>> >>>>>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>>>>> Add a flag allowing Nouveau to specify that an object should be coherent >>>>>>> at allocation time. This is required for some class of objects like >>>>>>> fences which are randomly-accessed by both the CPU and GPU. This flag >>>>>>> instructs the kernel driver to make sure the object remains coherent >>>>>>> even on architectures for which coherency is not guaranteed by the bus. >>>>>>> >>>>>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>>>>> I don't see a problem with this patch, but similar patches to intel to >>>>>> libdrm have been shot down when the changes weren't in an official kernel >>>>>> yet, so I think this should wait until the change is at least in drm-next. >>>>>> ;-) >>>>> Sounds good. I will ping you again once the kernel change reaches -next. >>>> Hi Marteen, >>>> >>>> The kernel change required for this patch is now in -next. Do you >>>> think we can merge it now? >> I think it would be ok to merge now. > Great - who could do this? :PI could do it. Please provide me with the patch with the necessary R-b and I can push it to our libdrm (and/or mesa).
Alexandre Courbot
2015-May-21 06:09 UTC
[Nouveau] [PATCH] nouveau: add coherent BO attribute
On Wed, May 20, 2015 at 3:53 PM, Martin Peres <martin.peres at free.fr> wrote:> On 20/05/15 08:11, Alexandre Courbot wrote: >> >> On Fri, May 15, 2015 at 8:39 PM, Maarten Lankhorst >> <maarten at mblankhorst.nl> wrote: >>> >>> Op 15-05-15 om 09:11 schreef Alexandre Courbot: >>>> >>>> Re-pinging Marteen on an email address that still exists :P >>>> >>>> On Wed, Apr 22, 2015 at 6:08 PM, Alexandre Courbot <gnurou at gmail.com> >>>> wrote: >>>>> >>>>> On Sun, Mar 15, 2015 at 5:41 PM, Alexandre Courbot >>>>> <acourbot at nvidia.com> wrote: >>>>>> >>>>>> On 03/14/2015 04:33 AM, Maarten Lankhorst wrote: >>>>>>> >>>>>>> Hey, >>>>>>> >>>>>>> Op 13-03-15 om 07:27 schreef Alexandre Courbot: >>>>>>>> >>>>>>>> Add a flag allowing Nouveau to specify that an object should be >>>>>>>> coherent >>>>>>>> at allocation time. This is required for some class of objects like >>>>>>>> fences which are randomly-accessed by both the CPU and GPU. This >>>>>>>> flag >>>>>>>> instructs the kernel driver to make sure the object remains coherent >>>>>>>> even on architectures for which coherency is not guaranteed by the >>>>>>>> bus. >>>>>>>> >>>>>>>> Signed-off-by: Alexandre Courbot <acourbot at nvidia.com> >>>>>>> >>>>>>> I don't see a problem with this patch, but similar patches to intel >>>>>>> to >>>>>>> libdrm have been shot down when the changes weren't in an official >>>>>>> kernel >>>>>>> yet, so I think this should wait until the change is at least in >>>>>>> drm-next. >>>>>>> ;-) >>>>>> >>>>>> Sounds good. I will ping you again once the kernel change reaches >>>>>> -next. >>>>> >>>>> Hi Marteen, >>>>> >>>>> The kernel change required for this patch is now in -next. Do you >>>>> think we can merge it now? >>> >>> I think it would be ok to merge now. >> >> Great - who could do this? :P > > > I could do it. Please provide me with the patch with the necessary R-b and I > can push it to our libdrm (and/or mesa).Thanks, I just sent a v2 with you included. I have yet to receive formal R-b and A-b for it though.