Nouveau - Apr 2015 - [Bug 89969] New: vaDriverInit fails with gallium/nouveau driver

https://bugs.freedesktop.org/show_bug.cgi?id=89969

            Bug ID: 89969
           Summary: vaDriverInit fails with gallium/nouveau driver
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: julien.isorce at gmail.com
        QA Contact: nouveau at lists.freedesktop.org

Created attachment 114987
  --> https://bugs.freedesktop.org/attachment.cgi?id=114987&action=edit
build: enable va with nouveau driver

When running vainfo:

libva info: VA-API version 0.37.1
libva info: va_getDriverName() returns 0
libva info: User requested driver 'gallium'
libva info: Trying to open /usr/local/lib/dri/gallium_drv_video.so
libva info: Found init function __vaDriverInit_0_37
libva error: /usr/local/lib/dri/gallium_drv_video.so init failed
libva info: va_openDriver() returns 2
vaInitialize failed with error code 2 (resource allocation failed),exit

"vl_screen_create" calls "dd_create_screen" which returns
NULL because the
block

#if defined(GALLIUM_NOUVEAU)
   if (strcmp(driver_name, "nouveau") == 0)
      return pipe_nouveau_create_screen(fd);
   else
#endif

is not compiled for va target. Indeed GALLIUM_NOUVEAU is not defined at this
point. See following patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/0deb9762/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Does it actually work though? (i.e. decode videos, display them, etc)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/5646a4ba/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #2 from Emil Velikov <emil.l.velikov at gmail.com> ---
It didn't last time I've checked. st/va requires chunked decoding which
nouveau
does not support atm.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/f95f11d6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #3 from Julien Isorce <julien.isorce at gmail.com> ---
basic libva unit tests passes but it fails to decode 2 videos mpeg12
(nouveau_vp3_fill_picparm_mpeg12_bsp) and h264
(nouveau_vp3_fill_picparm_h264_bsp).

nouveau_vp3_fill_picparm_mpeg12_bsp (map=0x7ffff7e3c000 <error: Cannot access
memory at address 0x7ffff7e3c000>, desc=0x0, dec=0x7fffe004a000)
    at nouveau_vp3_video_bsp.c:121
121       pic_bsp->picture_structure = desc->picture_structure;
(gdb) bt
#0  nouveau_vp3_fill_picparm_mpeg12_bsp (map=0x7ffff7e3c000 <error: Cannot
access memory at address 0x7ffff7e3c000>, desc=0x0, dec=0x7fffe004a000)
    at nouveau_vp3_video_bsp.c:121
#1  nouveau_vp3_bsp (dec=dec at entry=0x7fffe004a000, desc=desc at entry=...,
target=target at entry=0x7fffe001fe00, comm_seq=comm_seq at entry=2, 
    num_buffers=num_buffers at entry=1, data=data at entry=0x7fffe7ffdcd0,
num_bytes=num_bytes at entry=0x7fffe7ffdcc0) at nouveau_vp3_video_bsp.c:257
#2  0x00007ffff072118e in nvc0_decoder_bsp (dec=dec at entry=0x7fffe004a000,
desc=desc at entry=..., target=target at entry=0x7fffe001fe00,
comm_seq=comm_seq at entry=2, 
    num_buffers=1, data=0x7fffe7ffdcd0, num_bytes=0x7fffe7ffdcc0,
vp_caps=vp_caps at entry=0x7fffe7ffdbd8, is_ref=is_ref at entry=0x7fffe7ffdbdc, 
    refs=refs at entry=0x7fffe7ffdbe0) at nvc0/nvc0_video_bsp.c:117
#3  0x00007ffff0721650 in nvc0_decoder_decode_bitstream
(decoder=0x7fffe004a000, video_target=0x7fffe001fe00, picture=0x0,
num_buffers=<optimised out>, 
    data=<optimised out>, num_bytes=<optimised out>) at
nvc0/nvc0_video.c:48

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe7fff700 (LWP 854)]
nouveau_vp3_bsp (dec=dec at entry=0x7fffe0068040, desc=desc at entry=...,
target=target at entry=0x7fffe0063110, comm_seq=comm_seq at entry=2, 
    num_buffers=num_buffers at entry=2, data=data at entry=0x7fffe7ffe150,
num_bytes=num_bytes at entry=0x7fffe7ffe140) at nouveau_vp3_video_bsp.c:270
270          caps = nouveau_vp3_fill_picparm_h264_bsp(dec, desc.h264, bsp);
(gdb) bt
#0  nouveau_vp3_bsp (dec=dec at entry=0x7fffe0068040, desc=desc at entry=...,
target=target at entry=0x7fffe0063110, comm_seq=comm_seq at entry=2, 
    num_buffers=num_buffers at entry=2, data=data at entry=0x7fffe7ffe150,
num_bytes=num_bytes at entry=0x7fffe7ffe140) at nouveau_vp3_video_bsp.c:270
#1  0x00007ffff02a918e in nvc0_decoder_bsp (dec=dec at entry=0x7fffe0068040,
desc=desc at entry=..., target=target at entry=0x7fffe0063110,
comm_seq=comm_seq at entry=2, 
    num_buffers=2, data=0x7fffe7ffe150, num_bytes=0x7fffe7ffe140,
vp_caps=vp_caps at entry=0x7fffe7ffe058, is_ref=is_ref at entry=0x7fffe7ffe05c, 
    refs=refs at entry=0x7fffe7ffe060) at nvc0/nvc0_video_bsp.c:117
#2  0x00007ffff02a9650 in nvc0_decoder_decode_bitstream
(decoder=0x7fffe0068040, video_target=0x7fffe0063110, picture=0x0,
num_buffers=<optimised out>, 
    data=<optimised out>, num_bytes=<optimised out>) at
nvc0/nvc0_video.c:48

Worth to mention that gallium/vdpau succeeds to decode these 2 videos. Also
libva succeeds to decode video using libva's vdpau-driver on top of
gallium/vdpau.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/911e7fa9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #4 from Emil Velikov <emil.l.velikov at gmail.com> ---
Seems (almost) identical to the ones I've seen. Iirc the debug build does
assert out a bit earlier.

If interested you can take a look at adding the missing functionality (to
drivers/nouveau) but as-is I'm not sure what nouveau can work with st/va :-\

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/8f8b5c64/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
I am interested but I would need some infos to start :)

Also I do not understand why a functionality is missing in drivers/nouveau
since st/vdpau works (which means nouveau_vp3_fill_picparm_mpeg12_bsp and
nouveau_vp3_fill_picparm_h264_bsp work).

So I was suspecting something wrong in st/va/picture.c
Using the above bt, I noticed that for st/vpdau
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/vdpau/decode.c#n557
the third param is well defined.
Whereas for st/va
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/picture.c#n520
the third param is NULL which leads to the crash.

Few minutes ago I tried naively to replace this NULL param with
"&context->desc.base" but then I can see a wrong image in my
application when
rendering decoded images.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/5ef03708/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #6 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Unlike public API's, gallium API's are fluid and not extremely
well-defined.
They're primarily defined by the existing users, and secondarily by
documentation when those users disagree. Video API's are especially poorly
defined, as there are only 2 real driver implementations (radeon + nouveau),
and until recently, only st/xvmc and st/vdpau (and everyone except me hates
st/xvmc).

I believe that st/va had to make some changes to how functions were called and
what parameters they were allowed to have, but the updates were only made to
the radeon drivers. Unfortunately I don't know what those updates were. Emil
mentioned chunked decoding, but I don't really know what that is. Perhaps
you
can look at the st/va enablement patches for radeon and see what all they had
to change.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/29e78a80/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #7 from Christian König <deathsimple at vodafone.de> ---
Chunked decoding means that between begin picture and end picture the state
tracker calls the decode function multiple times for the same picture.

E.g. you don't get the bitstream all at once, but rather in small chunks.

Nouveau can't deal with that cause Maarten didn't wanted that interface,
radeon
on the other hand never used anything else.

You just need to fix nouveau to implement bitstream buffer resizing in the same
way radeon does it (or move that stuff into the state tracker like I always
suggested).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150409/72c1529e/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #8 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117214
  --> https://bugs.freedesktop.org/attachment.cgi?id=117214&action=edit
WIP - nouveau: add support for chunk decoding


A: resize buffer in nvc0_decoder_bsp:
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nvc0/nvc0_video_bsp.c#n73

B: memcpy of the data in nouveau_vp3_bsp:
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video_bsp.c#n294

For radeon driver it both happens in ruvd_decode_bitstream.

To compare radeon to nouveau:

struct ruvd_decoder.bs_buffers is an array of struct rvid_buffer that hold a
ref on struct r600_resource, aka pipe_resource.

struct nouveau_vp3_decoder.bsp_bo is an array of struct nouveau_bo (which comes
from libdrm/nouveau library)

So if I am right, in the function nvc0_decoder_decode_bitstream it should
resize the nouveau_bo buffers and store current data, i.e. A and B. 

So I made a patch that first splits nvc0_decoder_bsp to extract A and B into a
new function nvc0_decoder_bsp_next_chunk. The remaining part of
nvc0_decoder_bsp go to nvc0_decoder_bsp_end_frame.

I just realize the patch is missing the preserving part while resizing buffers
(equivalent of the memcpy in rvid_resize_buffer
http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/radeon/radeon_video.c#n100)
that could explain why it is still not working.

But I wanted to know if I am on the right track or not ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150717/2e6e09c5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117214|0                           |1
        is obsolete|                            |

--- Comment #9 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117215
  --> https://bugs.freedesktop.org/attachment.cgi?id=117215&action=edit
WIP - nouveau: add support for chunk decoding

Actual wip patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150717/3609ec66/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #10 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Wouldn't it be simpler to just accumulate user buffers and then do all the
work
in end_frame instead? And like Christian said, it'd be easy enough to get
st/va
to do this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150717/9a198a45/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #11 from Christian König <deathsimple at vodafone.de> ---
(In reply to Ilia Mirkin from comment #10)
> Wouldn't it be simpler to just accumulate user buffers and then do all
the
> work in end_frame instead? And like Christian said, it'd be easy enough
to
> get st/va to do this.
Accumulating all the user buffers in the state tracker is what I initially
suggested as well and I wouldn't mind if it goes into this direction in the
long term.

You would need to add a new type for the bitstream buffer (we currently already
abuse vertext buffers in the OMX encoder for this).

For the short term your patch looks like it's going into the right
direction.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150718/75d2cdbf/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117215|0                           |1
        is obsolete|                            |

--- Comment #12 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117358
  --> https://bugs.freedesktop.org/attachment.cgi?id=117358&action=edit
WIP - nouveau: add support for chunk decoding

I updated patch since I miss understood some parts last time.
Preserving data while resizing is commented out for testing since the initial
buffer is big enough for the stream I tried.
The patch keeps st/vdpau working but st/va still does not work.
Indeed it shows a green frame. I do not see any shape but I see some pixels
that let me think it does something.

How can I be sure it is not a problem from st/va ? I assume it works with
radeon (only radeon for now ? according to src/gallium/targets/va/Makefile.am I
was expecting intel too)
For nouveau, maybe it requires to do more work on st/va side.
I can try to go for the other solution to compare.

Which internal or external unit tests can I use ? Also if you have an idea how
I can debug this ?

Maybe I can compare what contains the nouveau_bo buffer between one begin/end,
between vdpau and va ? Not sure if they should contain the exact same thing at
the time _end is called.

Thx

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150724/eda7fb72/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #13 from Ilia Mirkin <imirkin at alum.mit.edu> ---
You can compare what's going on in the two cases by using valgrind-mmt
(http://nouveau.freedesktop.org/wiki/Valgrind-mmt/) in combination with the
demmt tool in envytools. However it will be quite tough to tell what's going
on
since the interesting stuff passed around in buffers rather than sending
commands in the fifo. You should still see the buffers being written though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150724/a8c15659/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #14 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117399
  --> https://bugs.freedesktop.org/attachment.cgi?id=117399&action=edit
2 valgrind outputs to compare failure case with working reference case

Failure:
LIBVA_DRIVER_NAME=gallium valgrind --tool=mmt --mmt-trace-nouveau-ioctls
--log-file=va_mesa_bin.log gst-launch-1.0 filesrc
location=/home/SERILOCAL/j.isorce/Downloads/centaur_2.mpg num-buffers=6 !
mpegpsdemux ! mpegvideoparse ! vaapideco^C ! tee ! vdieoconvert ! xvimagesink

Success:
LIBVA_DRIVER_NAME=vdpau valgrind --tool=mmt --mmt-trace-nouveau-ioctls
--log-file=va_over_vdpau_mesa_bin.log gst-launch-1.0 filesrc
location=/home/SERILOCAL/j.isorce/Downloads/centaur_2.mpg num-buffers=6 !
mpegpsdemux ! mpegvideoparse ! vaapidecode ! tee ! videoconvert ! xvimagesink

Where should I look at in these 2 logs to compare what contain the nouveau_bo
buffer between the first st/va being/end frame ? (using demmt -l)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150727/42acb2e0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117358|0                           |1
        is obsolete|                            |
 Attachment #117399|0                           |1
        is obsolete|                            |

--- Comment #15 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117910
  --> https://bugs.freedesktop.org/attachment.cgi?id=117910&action=edit
WIP - nouveau: add support for chunk decoding

It now works on mpeg12 using vlc+vaapi+mesa/st/va/nouveau. The problem from the
last patch was that the "desc" was written to the nouveau_bo before
being
actually updated. 

vdpau backend still works, and vaapi backend using vdpau works too.

But for now the video is not showing correctly using gstreamer-vaapi so I need
to investigate this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150825/67b207c8/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117910|0                           |1
        is obsolete|                            |

--- Comment #16 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 117910
  --> https://bugs.freedesktop.org/attachment.cgi?id=117910
WIP - nouveau: add support for chunk decoding

Actually it works with GStreamer too using vaapisink. So I am going to submit
patches to mailing list. I splited it in 8 patches to make it more clear.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/a9c08152/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114987|0                           |1
        is obsolete|                            |

--- Comment #17 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 114987
  --> https://bugs.freedesktop.org/attachment.cgi?id=114987
build: enable va with nouveau driver

Will be submitted to mailing list

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/2b46a1be/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|vaDriverInit fails with     |nouveau: add support for
                   |gallium/nouveau driver      |chunk decoding in order to
                   |                            |support vaapi (st/va)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/cb7aae16/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #18 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117928
  --> https://bugs.freedesktop.org/attachment.cgi?id=117928&action=edit
[PATCH 0/8] nouveau: add support for vaapi

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/e5537650/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #19 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117929
  --> https://bugs.freedesktop.org/attachment.cgi?id=117929&action=edit
[PATCH 1/8] nouveau: extract memcpy loop from nouveau_vp3_bsp

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/44215fcb/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #20 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117930
  --> https://bugs.freedesktop.org/attachment.cgi?id=117930&action=edit
[PATCH 2/8] nouveau: remove nouveau_vp3_bsp to use begin/next/end

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/da12d446/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #21 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Please post patches to list so that they may be reviewed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/1a702bb4/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #22 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117931
  --> https://bugs.freedesktop.org/attachment.cgi?id=117931&action=edit
[PATCH 3/8] nouveau: split nvc0_decoder_bsp in begin/next/end

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/1a749c5b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #23 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117932
  --> https://bugs.freedesktop.org/attachment.cgi?id=117932&action=edit
[PATCH 4/8] nouveau: preserve content buffer when calling nvc0_decoder_bsp_next

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/17fc7b68/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #24 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117934
  --> https://bugs.freedesktop.org/attachment.cgi?id=117934&action=edit
[PATCH 5/8] nouveau: remove nvc0_decoder_bsp and use begin/next/end instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/c68179b3/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #25 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117936
  --> https://bugs.freedesktop.org/attachment.cgi?id=117936&action=edit
[PATCH 6/8] nvc0: implement pipe_video_codec::begin_frame/end_frame

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/ffedbd40/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #26 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117937
  --> https://bugs.freedesktop.org/attachment.cgi?id=117937&action=edit
[PATCH 7/8] nouveau: fix chunk decoding by updating number of slices

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/0a4439f6/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #27 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117938
  --> https://bugs.freedesktop.org/attachment.cgi?id=117938&action=edit
[PATCH 8/8] build: enable st/va with nouveau driver

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/6bb74fca/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #28 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Ilia Mirkin from comment #21)
> Please post patches to list so that they may be reviewed.
I cannot send them using git send-email. I am behind a proxy so I think
that's
why I cannot.
That's why I attached them here. And home computer is broken for now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/21fc6c2d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #29 from Julien Isorce <julien.isorce at gmail.com> ---
Created attachment 117939
  --> https://bugs.freedesktop.org/attachment.cgi?id=117939&action=edit
Contains files generated with git send-email

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150826/d93c14b5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117928|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/ebcb848b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117930|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/ee67794a/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117938|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/3aece59a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117934|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/40cb8930/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117937|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/7c4bc6a2/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117936|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/1a9df035/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117932|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/8f955d89/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117931|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/5dbf6b72/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117929|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/79c35e11/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117939|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/c7855064/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

--- Comment #30 from Julien Isorce <julien.isorce at gmail.com> ---
Patches have been sent to mailing list for review.

vc1, mpeg12, mpeg4 are working but not h264 (visible but lot of blockiness)

Need someone to try existing st/va with a radeon card and using:
LIBVA_DRIVER_NAME=gallium mpv --hwdec=vaapi anyH264Video.mp4

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20150916/da10a70d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=89969

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #31 from Julien Isorce <julien.isorce at gmail.com> ---
Fixed in current master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20160205/314d4a3d/attachment.html>