Nouveau - Jan 2013 - [Bug 58984] New: DRM NOUVEAU: probe of 0001:01:00.0 failed with error -12

https://bugs.freedesktop.org/show_bug.cgi?id=58984

          Priority: medium
            Bug ID: 58984
          Assignee: nouveau at lists.freedesktop.org
           Summary: DRM NOUVEAU: probe of 0001:01:00.0 failed with error
                    -12
        QA Contact: xorg-team at lists.x.org
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: baggett.patrick at gmail.com
          Hardware: SPARC
            Status: NEW
           Version: git
         Component: Driver/nouveau
           Product: xorg

When booting a Sun Blade 2500 with a GeForce 8400 GS PCI, everything appears
pretty normal but for no apparent reason, the probe fails. It looks like error
-12 is "out of memory", but bug 56721 which looks similar does not
apply. My
machine also has 6GB of memory, so I'm sure it isn't actually failing to
allocate system memory.

Running Linux 3.8-rc1 git and nouveau git from last night (Jan 2 2013).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130103/dd59825a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #1 from Patrick Baggett <baggett.patrick at gmail.com> ---
Doh, dmesg.log didn't attach. I'll get that later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130103/dceaee39/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #2 from Patrick Baggett <baggett.patrick at gmail.com> ---
Created attachment 72491
  --> https://bugs.freedesktop.org/attachment.cgi?id=72491&action=edit
dmesg output

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130103/c6e749b3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #3 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
Please attach kernel log with nouveau.debug=trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130104/1b635a23/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #4 from Patrick Baggett <baggett.patrick at gmail.com> ---
Created attachment 72526
  --> https://bugs.freedesktop.org/attachment.cgi?id=72526&action=edit
dmesg output with tracing enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130104/eb8a7c30/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #5 from Patrick Baggett <baggett.patrick at gmail.com> ---
It's odd, I don't see any obvious errors, it just finalizes after the
DCB
messages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130105/b470e4f7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

Emil Velikov <emil.l.velikov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freedesktop.or
                   |                            |g/show_bug.cgi?id=58087

--- Comment #6 from Emil Velikov <emil.l.velikov at gmail.com> ---
Appears to be failing in nouveau_display.c

nouveau_display_create(struct drm_device *dev)
...
296:    disp = drm->display = kzalloc(sizeof(*disp), GFP_KERNEL);
    if (!disp)
        return -ENOMEM;
...

See
https://bugzilla.kernel.org/show_bug.cgi?id=51301
https://lkml.org/lkml/2012/11/27/486

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130105/c7f9620f/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #7 from Patrick Baggett <baggett.patrick at gmail.com> ---
This is still present in 3.8 RC kernels? I saw a bunch of patches posted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130105/0d5bcbfd/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #8 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
Can you sprinkle printks in nouveau_drm_load around nouveau_bios_init (and go
deeper) and figure out what is actually failing? I doubt it's the line Emil
thinks it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130105/0b6490ed/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #9 from Patrick Baggett <baggett.patrick at gmail.com> ---
I added some printk()s starting from nouveau_drm_load(), and
nouveau_display_create() is returning -12.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130109/ea49fb0b/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #10 from Patrick Baggett <baggett.patrick at gmail.com> ---
Do you need me to go further and add some printk()s in
nouveau_display_create()? It looks like Emil may be correct. If so -- is there
a fix for this issue applied to the kernel git yet?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130110/7ff1c4a8/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #11 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
Yes, please go further.
I'm not aware of any patch fixing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130110/a578cdf1/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #12 from Patrick Baggett <baggett.patrick at gmail.com> ---
OK, I found some time to dig into this. I'm now running linux + nouveau git
latest.

The error continues into nv50_display_create(), where nouveau_bo_new() returns
-12. Tracing into nouveau_bo_new(), the function ttm_bo_init() fails with -12.
This seems to be "outside" of the nouveau driver, however, since
I've had
success with nouveau using NV17 hardware, I thought perhaps that the parameters
were somehow problematic.

I see these integer (non-pointer/boolean) parameters to ttm_bo_init():

size = 8192
type = 0
align >> PAGE_SHIFT = 0
acc_size = 17536


PAGE_SHIFT = 13


SPARC has 8KB pages by default (1<<13), if that helps explain anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130313/02167f31/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #13 from Patrick Baggett <baggett.patrick at gmail.com> ---
Hmm, so I saw nouveau_bo_new() has this line:

nvbo->page_shift = 12

That imples a page size of 4KB (default on 32-bit x86). When I changed it to
"nvbo->page_shift = PAGE_SHIFT", the problem was fixed!

I now see as the final message:

[drm] Initialized nouveau 1.1.0 20120801 for 0001:01:00.0 on minor 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130313/14b38e08/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #14 from Marcin Slusarz <marcin.slusarz at gmail.com> ---
As you mentioned in the mailing list post that there are other problems after
"fixing" this bug, I think the problem is more widespread.

If page size on GPU is unconnected to page size on CPU (I think it's more
likely than the other option), we need to have our own macros for PAGE_SHIFT /
PAGE_MASK / PAGE_SIZE for GPU and use them everywhere, OR use existing CPU
macros consistently (there are a lot of places using "12" constant).

Either way it's not as simple as this oneliner...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130313/7c75051a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #15 from Patrick Baggett <baggett.patrick at gmail.com> ---
Hmm, that does make sense. Alright then, since you seem to have more of an idea
of what is going on, how can I help?

Which makes sense / is the right route? A private PAGE_SHIFT|MASK|SIZE for GPUs
or using the system page size consistently? Are all NV GPUs that support paging
using 4K pages? (I say "support paging" because I had an NV17 GPU that
worked
fine on SPARC, OpenGL games worked and all).

Should I just audit nouveau/*.c for any usage of "12" and try changing
it to
PAGE_SHIFT to see what happens? Guide me and I'll do all the annoying busy
work. ;)


Patrick

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130313/fcd703be/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #16 from Marcin Ko?cielnicki <koriakin at 0x04.net> ---
(In reply to comment #15)
> Which makes sense / is the right route? A private PAGE_SHIFT|MASK|SIZE for
> GPUs or using the system page size consistently? Are all NV GPUs that
> support paging using 4K pages? (I say "support paging" because I
had an NV17
> GPU that worked fine on SPARC, OpenGL games worked and all).
> 
All nvidia GPUs all the way back to NV01 support 4kB pages (with NV50-gen ones
also supporting 16kB + 64kB and NVC0-gen also supporting 128kB, but these sizes
are usually only used for VRAM and not system RAM).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130313/49730f34/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

--- Comment #17 from Patrick Baggett <baggett.patrick at gmail.com> ---
Hey all,

I was looking to audit the use of 12/PAGE_SHIFT in nouveau to help determine
the context of what is meant (i.e. host CPU page size or GPU page size?).
Marcin  Slusarz suggested that there be a private PAGE_XXX macro for NV cards;
would these then be 4KB pages only? I realize the GPUs may support other sizes,
but my understanding of the current situation is that they are not supported by
the current driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130513/4f203fda/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|DRM NOUVEAU: probe of       |[NV98] Probe error on SPARC
                   |0001:01:00.0 failed with    |with 8kb pages
                   |error -12                   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20130820/11581c53/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

Emil Velikov <emil.l.velikov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freedesktop.or
                   |                            |g/show_bug.cgi?id=71900

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20131213/fabc589d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=58984

Martin Peres <martin.peres at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #18 from Martin Peres <martin.peres at free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/issues/33.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20191204/6a3991fe/attachment.html>