Marcin Slusarz
2012-Nov-15 21:09 UTC
[Nouveau] [PATCH] drm/nouveau/bios: fix DCB v1.5 parsing
memcmp->nv_strncmp conversion should have inverted the return value.
Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com>
---
See
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/nouveau_bios.c;h=a0a3fe3c016be86665db1369c44bef832f829a1a;hb=a0d271cbfed1dd50278c6b06bead3d00ba0a88f9#l5652
(3.6)
and
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/core/include/core/object.h;h=818feabbf4a0969f090f897852fe4476a422b1b6;hb=77b67063bb6bce6d475e910d3b886a606d0d91f7#l179
(nv_strncmp definition)
---
drivers/gpu/drm/nouveau/core/subdev/bios/dcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/dcb.c
b/drivers/gpu/drm/nouveau/core/subdev/bios/dcb.c
index 7d75038..acb6936 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/dcb.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bios/dcb.c
@@ -64,7 +64,7 @@ dcb_table(struct nouveau_bios *bios, u8 *ver, u8 *hdr, u8
*cnt, u8 *len)
}
} else
if (*ver >= 0x15) {
- if (!nv_strncmp(bios, dcb - 7, 7, "DEV_REC")) {
+ if (nv_strncmp(bios, dcb - 7, 7, "DEV_REC")) {
u16 i2c = nv_ro16(bios, dcb + 2);
*hdr = 4;
*cnt = (i2c - dcb) / 10;
--
1.7.12
Dave Airlie
2012-Nov-16 11:36 UTC
[Nouveau] [PATCH] drm/nouveau/bios: fix DCB v1.5 parsing
On Fri, Nov 16, 2012 at 7:09 AM, Marcin Slusarz <marcin.slusarz at gmail.com> wrote:> memcmp->nv_strncmp conversion should have inverted the return value. > > Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com> > --- > See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/nouveau_bios.c;h=a0a3fe3c016be86665db1369c44bef832f829a1a;hb=a0d271cbfed1dd50278c6b06bead3d00ba0a88f9#l5652 (3.6) > and http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/core/include/core/object.h;h=818feabbf4a0969f090f897852fe4476a422b1b6;hb=77b67063bb6bce6d475e910d3b886a606d0d91f7#l179 (nv_strncmp definition)Christ fix that nv_strncmp to act like the C one, or give it a very different name! Dave.