Nouveau - Jan 2012 - [Bug 35452] Pageflipping + nouveau + compiz + fullscreen == FAIL

https://bugs.freedesktop.org/show_bug.cgi?id=35452

Jeremy Huddleston <jeremyhu at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|xorg-team at lists.x.org       |nouveau at
lists.freedesktop.o
                   |                            |rg
          Component|Server/General              |Driver/nouveau

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #19 from Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
2012-01-04 08:34:01 UTC ---
Hi,

can you try the two patches i just attached against the nouveau ddx?

They are direct translations of what is done in the ati-ddx and intel-ddx. They
fix the same problem for me. Technically they are independent of each other,
but the 2nd one (the fix for your problem) doesn't apply without the first
one
atm. Also i wanted to resubmit them for review anyway, so you can be my first
independent tester.

Both have been successfully tested by me a couple of months ago, i've just
rebased them against nouveau master. They compile successfully but i haven't
retested them yet.

The first patch in the series was held back, because Francisco Jerez didn't
want to have it before the x-server implements a proper swaplimit api, but
xorg-1.12rc has the api now, so i wanted to resubmit this series anyway.

-mario

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #17 from Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
2012-01-04 08:21:24 PST ---
Created attachment 55116
  --> https://bugs.freedesktop.org/attachment.cgi?id=55116
Fix pageflip completion handling and timestamping on noveau ddx.

Patch 0002, the proposed bugfix for nouveau trivially depends on this one at
the moment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #18 from Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
2012-01-04 08:23:06 PST ---
Created attachment 55117
  --> https://bugs.freedesktop.org/attachment.cgi?id=55117
Bugfix for nouveau, a direct translation of the bugfix in ati-ddx for same
problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #20 from maximlevitsky at gmail.com 2012-01-04 09:40:18 PST ---
Just one question, do I need to update xserver for this? I am using some
unknown xserver revision from git and usually updating xserver is quite painful
process.

I currently use this revision + patch that 'fixes' this issue but slows
everything down as I said before.

I am on:


commit 4020cab88f5cf3164fc83cf912f94f288aa5a45d
Author: Michel D?nzer <michel.daenzer at amd.com>
Date:   Wed Aug 10 11:36:16 2011 +0200

    EXA/mixed: Update sys_pitch in MPH even when there's no system memory
copy.

    Otherwise sys_pitch will be stale when a system memory copy is allocated.

    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=38322 and a crash when
    unlocking the screen with xscreensaver, reported by Janne Huttunen.

    Signed-off-by: Michel D?nzer <michel.daenzer at amd.com>
    Tested-by: Janne Huttunen <jahuttun at gmail.com>
    Tested-by: Jan Kriho <Erbureth at gmail.com>
    Signed-off-by: Keith Packard <keithp at keithp.com>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #21 from maximlevitsky at gmail.com 2012-01-04 09:57:22 PST ---
Just tested, appears to be working. FPS didn't increase as much as I
expected,
I will test this more thoughtfully.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #22 from maximlevitsky at gmail.com 2012-01-04 10:22:36 PST ---
OK, here are the full results:

All tests done without any composition manager using specific scene from
neverball with accuracy +=1FPS:

1. without any patches: 100 FPS
2. with your patch: 94 FPS
3. with ugly xserver workaround I used before: 84 FPS

Then I tested with kwin and 'unredirect full screen windows' option, and
I
confirm that your patch indeed fixes the issue, the issue of crazy kwin after I
end the game 

(I had this with compiz as well - had to stop using it, its just too buggy
nowadays and its not nouveau fault, I checked, besides kwin finally is good
both performance and feature wise, and integrates well into KDE).

Also I noticed though that if I don't redirect full screen windows (and I
don't
as I prefer just to disable composing - its easy with kwin, and I had enough of
problems with this option, everything works fine without any patches. Thus if I
forget to disable composing, game runs, abet slow - 67 FPS).

So thanks, but it would be great somehow to eliminate the overhead in case
composing manager is not running, which not the case yet.

Thank a lot for looking into this,
Best regards,
     Maxim Levitsky

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=35452

--- Comment #23 from Mario Kleiner <mario.kleiner at tuebingen.mpg.de>
2012-01-04 14:51:30 PST ---
Good. You can try with the 2nd patch only if you want. That should fix your bug
and should give you an idea of the performance you'll get. The 2nd patch
does
not apply cleanly because of some context it needs from the 1st patch, but you
can fix this manually. ("Bugfix for nouveau, a direct translation of the
bugfix
in ati-ddx for same problem.")

The 1st patch fixes other bugs, but potentially reduces fps a little bit by
reducing kms-flips from triple-buffered to double-buffered, probably causing
your lost 6 fps wrt. no fix applied at all.

1st patch wasn't applied to nouveau because of this. But Xserver 1.12 has a
new
swaplimit api that should allow to apply the 1st patch without performance
loss, once we have a patch using the swaplimit api.

I'll prepare those additional patch in the next couple of days and submit
them
to nouveau-devel.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.