Nouveau - May 2011 - [Bug 36744] New: [NVA5] BUG: unable to handle kernel NULL pointer dereference

https://bugs.freedesktop.org/show_bug.cgi?id=36744

           Summary: [NVA5] BUG: unable to handle kernel NULL pointer
                    dereference
           Product: xorg
           Version: unspecified
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: patmandin at gmail.com
         QAContact: xorg-team at lists.x.org


Created an attachment (id=46222)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46222)
Kernel log

Since commit e5ca5dec3111772ade1cbbead50c0c594a49778d (bisected, drm/nouveau:
remove remnants of nouveau_pgraph_engine) to nouveau/linux-2.6, I get NULL
pointer dereference when starting kernel.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=36744

--- Comment #1 from Patrice Mandin <patmandin at gmail.com> 2011-05-06
13:08:25 PDT ---
Booting kernel without 'nouveau.noaccel=1' makes it work. So it appears
the
noaccel case has been broken by said git commit.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=36744

--- Comment #2 from Patrice Mandin <patmandin at gmail.com> 2011-05-23
02:11:14 PDT ---
In nouveau_card_init() function (nouveau_state.c file), engine->fifo.init()
function is not called when nouveau_noaccel is enabled.

On NV50/NVA0 cards, engine->fifo.init = nv50_fifo_init (nv50_fifo.c file) and
this function is responsible to fill pfifo->playlist array, which is not done
with nouveau_noaccel enabled.

When nv50_fifo_playlist_update() is called, accessing pfifo->playlist (which
was not initialized) triggers the NULL pointer dereference.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

https://bugs.freedesktop.org/show_bug.cgi?id=36744

Patrice Mandin <patmandin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Patrice Mandin <patmandin at gmail.com> 2011-05-25
01:54:45 PDT ---
Fixed in git nouveau/linux-2.6 repository. Thanks darktama.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.