Lucas Stach
2011-Jan-30  09:54 UTC
[PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini
I broke this with my commit
07cfe0e7a820ecad078c04e9c2a102521709145d
This fixes fdo #33434
Signed-off-by: Lucas Stach <dev at lynxeye.de>
---
 drivers/gpu/drm/nouveau/nouveau_pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_pm.c
b/drivers/gpu/drm/nouveau/nouveau_pm.c
index fb846a3..f05c0cd 100644
--- a/drivers/gpu/drm/nouveau/nouveau_pm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_pm.c
@@ -443,7 +443,7 @@ nouveau_hwmon_fini(struct drm_device *dev)
 	struct nouveau_pm_engine *pm = &dev_priv->engine.pm;
 
 	if (pm->hwmon) {
-		sysfs_remove_group(&pm->hwmon->kobj, &hwmon_attrgroup);
+		sysfs_remove_group(&dev->pdev->dev.kobj, &hwmon_attrgroup);
 		hwmon_device_unregister(pm->hwmon);
 	}
 #endif
-- 
1.7.3.5
--=-sT8zv7WVdF2SNe8roBrX--
Lucas Stach
2011-Jan-30  10:06 UTC
[Nouveau] [PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini
Hi Ben, please push. This fixes https://bugs.freedesktop.org/show_bug.cgi?id=33434 where I messed up. -- Lucas
Ben Skeggs
2011-Jan-30  22:27 UTC
[Nouveau] [PATCH] drm/nouveau: correctly pair hwmon_init and hwmon_fini
On Sun, 2011-01-30 at 11:06 +0100, Lucas Stach wrote:> Hi Ben, >Hey Lucas, Thanks, pushed :) Ben.> please push. This fixes > https://bugs.freedesktop.org/show_bug.cgi?id=33434 where I messed up. > > -- Lucas