Marcin Slusarz
2010-Jan-24 18:27 UTC
[Nouveau] [mesa PATCH] nv50: fix uninitialized variable in nv50_revdep_reorder
"unsafe" is never initialized, but used
(found by valgrind)
---
src/gallium/drivers/nv50/nv50_program.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/gallium/drivers/nv50/nv50_program.c
b/src/gallium/drivers/nv50/nv50_program.c
index cfe8b48..6d9ac14 100644
--- a/src/gallium/drivers/nv50/nv50_program.c
+++ b/src/gallium/drivers/nv50/nv50_program.c
@@ -3275,7 +3275,7 @@ prep_inspect_insn(struct nv50_pc *pc, const struct
tgsi_full_instruction *insn)
static unsigned
nv50_revdep_reorder(unsigned m[4], unsigned rdep[4])
{
- unsigned i, c, x, unsafe;
+ unsigned i, c, x, unsafe = 0;
for (c = 0; c < 4; c++)
m[c] = c;
--
1.6.6
Ben Skeggs
2010-Jan-24 23:48 UTC
[Nouveau] [mesa PATCH] nv50: fix uninitialized variable in nv50_revdep_reorder
On Sun, 2010-01-24 at 19:27 +0100, Marcin Slusarz wrote:> "unsafe" is never initialized, but used > (found by valgrind)Pushed, plus the other three patches you pinged on. Ben.> --- > src/gallium/drivers/nv50/nv50_program.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/gallium/drivers/nv50/nv50_program.c b/src/gallium/drivers/nv50/nv50_program.c > index cfe8b48..6d9ac14 100644 > --- a/src/gallium/drivers/nv50/nv50_program.c > +++ b/src/gallium/drivers/nv50/nv50_program.c > @@ -3275,7 +3275,7 @@ prep_inspect_insn(struct nv50_pc *pc, const struct tgsi_full_instruction *insn) > static unsigned > nv50_revdep_reorder(unsigned m[4], unsigned rdep[4]) > { > - unsigned i, c, x, unsafe; > + unsigned i, c, x, unsafe = 0; > > for (c = 0; c < 4; c++) > m[c] = c;