Nouveau - May 2009 - Compiling xf86-video-nouveau with -Werror

Hello.

I was somewhat bored and started to hunt for compilation warnings.
Attaching a patch for some rather obvious (two unused vars, one uninited
external function).

It also complains about NV10EXAFallbackInfo_real in nv10_exa.c never
being used.
It is placed with the following condition:

#if 0
#define NV10EXAFallbackInfo(X,Y,Z,S,T)
NV10EXAFallbackInfo_real(X,Y,Z,S,T)
#else
#define NV10EXAFallbackInfo(X,Y,Z,S,T) do { ; } while (0)
#endif

Since I do not know if this codepath ever is needed even during
development I did not touch this in my patch.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: nouvea-warnings.patch
Type: text/x-patch
Size: 1162 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/nouveau/attachments/20090506/564071cd/attachment.bin

ons 2009-05-06 klockan 15:07 +0200 skrev Peter
Hjalmarsson:
> Hello.
> 
> I was somewhat bored and started to hunt for compilation warnings.
> Attaching a patch for some rather obvious (two unused vars, one uninited
> external function).
> 
After actually grepping the code it became obvious that you be better
off with for the external function include xf86drmMode.h somewhere, but
that I will leave to you.