Nouveau - Dec 2008 - [Bug 19203] New: X default modes no longer added

http://bugs.freedesktop.org/show_bug.cgi?id=19203

           Summary: X default modes no longer added
           Product: xorg
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: moondrake at gmail.com
         QAContact: xorg-team at lists.x.org


Some month's ago I could switch from my laptops native resolution 1024x768
to
800x600 or 640x480. The gpu or panel would do the scaling.

Recently this is no longer possible. The edid only contains the native 1024x768
resolution and the log no longer mentions checking the modes from the builtin
modepool.

The lower resolutions were quite useful for some games and videos.

danny


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #1 from Stuart Bennett <sb476 at cam.ac.uk>  2008-12-20
09:10:27 PST ---
Have you updated the xserver recently?  I could believe
http://cgit.freedesktop.org/xorg/xserver/commit/?id=81fd17f5f49cdd2c10d0bf3b7ddeb8b5953886a5
"Only add default modes if EDID supports continuous-frequency" might
have this
effect.

As far as nouveau ddx changes go, the scaling code was last touched on Aug
16-17th in 8a364682fd67c10c153cb0778c914a4754e82ddd and 
4cbbd44db614d250fdaaf648db2d70ec9bc2f6d9 if you want to try going back to a
previous version (though admittedly there could be unintentional subsequent
breakage)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #2 from Danny <moondrake at gmail.com>  2008-12-24 04:54:27
PST ---
I saw that commit, but thought my checkout was older than that. Today i
checked. It is not. I checked my EDID and byte 0x18 reads 0A, and thus misses
the gtf bit.

I'm not sure if GTF support equals "continuous frequency", but
still i would
like a solution for this problem. Is there any other way we can check if a
screen supports more than just the preferred mode? 

Perhaps the commit is too restricting, I imagine it would fix the bugs if it
didn't try to put screens in higher resolutions than the supported ones, but
still left it possible to use lower resolutions.

danny


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #3 from Danny <moondrake at gmail.com>  2008-12-25 04:46:33
PST ---
maybe something like this can be done for nouveau as well?

http://www.mail-archive.com/dri-devel at lists.sourceforge.net/msg36976.html


danny


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #4 from Stuart Bennett <sb476 at cam.ac.uk>  2009-01-06
13:29:40 PST ---
Created an attachment (id=21734)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=21734)
hacky patch

here's a bodge that should fix the immediate problem. I'm tempted to
wait and
see what the intel guys ultimately come up with in bug 19247 before committing
anything


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #5 from Danny <moondrake at gmail.com>  2009-01-07 20:56:21
PST ---
It's a bit too dodgy. For some reason it messes up the edid completely,
leading
to random modes and eventually the server stops. I post the logs later.

d.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #6 from Danny <moondrake at gmail.com>  2009-01-08 06:19:57
PST ---
Created an attachment (id=21806)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=21806)
Xorg log

This log file shows the errors after applying above patch. Haven:t really
researcher what is happening.

d.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #7 from Danny <moondrake at gmail.com>  2009-01-10 04:18:01
PST ---
OK, patch does not work because xf86OutputSetEDID has already been called once,
and the edid got applied to the output. Calling it again will not change the
current edid, but seems to add another one. Doing;
        if (nv_connector->edid)
                nv_connector->edid->features.msc |= 0x1;
in edid_sink_connected instead (before the firstxf86OutputSetEDID) seems to
work fine.

d.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #8 from Stuart Bennett <sb476 at cam.ac.uk>  2009-01-10
15:55:00 PST ---
problem is due to xf86OutputSetEDID freeing the previously set xf86MonPtr,
which is also the one we're trying to set (again):

if (output->MonInfo != NULL)
  xfree(output->MonInfo);
output->MonInfo = edid_mon;

I'd really prefer to not drag the EDID alteration into the detect path,
since
at that stage there's no encoder type set.  What if you defeat the above
NULL
check by adding "output->MonInfo = NULL;" just before the call to
xf86OutputSetEDID in munge_edid_for_scaler?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #9 from Danny <moondrake at gmail.com>  2009-02-06 06:57:11
PST ---
Created an attachment (id=22643)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22643)
hack in detect path


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #10 from Danny <moondrake at gmail.com>  2009-02-06 06:58:06
PST ---
Created an attachment (id=22644)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22644)
vanilla, without hack


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #11 from Danny <moondrake at gmail.com>  2009-02-06 07:00:12
PST ---
Created an attachment (id=22645)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22645)
hack with workaround that NULLs MonInfo

Last few comments logs for each situation.

The hack doesn't seem to work because a new entry seems to be created which
has
the msc bit set. But this entry is not for the current panel.

d.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203





--- Comment #12 from Stuart Bennett <sb476 at cam.ac.uk>  2009-02-08
06:35:17 PST ---
Created an attachment (id=22692)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22692)
New patch without multiple OutputSetEDID calls

Bizarre, I've no idea why the previous patch didn't work.  From the
attached
logs it even look like it did.  Here's a new patch taking a different and
possibly better approach though.  If this one doesn't work, please make logs
with `Option "ModeDebug" "on"' set in the xorg.conf.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=19203


Stuart Bennett <sb476 at cam.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Stuart Bennett <sb476 at cam.ac.uk>  2009-02-08
07:41:49 PST ---
30848dd378d05917c646a24df404846e6f9b2352


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.