netfilter buglog - Aug 2018 - [Bug 1275] New: if IPTC_DEBUG is defined, compiler reports errors

https://bugzilla.netfilter.org/show_bug.cgi?id=1275

            Bug ID: 1275
           Summary: if IPTC_DEBUG is defined, compiler reports errors
           Product: iptables
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: libiptc
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: cscnull at gmail.com

if IPTC_DEBUG is defined, compiler reports errors link this:

In file included from libip4tc.c:113:0:
libiptc.c: In function 'iptc_read_counter':
libiptc.c:194:62: error: incompatible type for argument 1 of 'do_check'
 #define CHECK(h) do { if (!getenv("IPTC_NO_CHECK")) do_check((h),
__LINE__); }
while(0)
                                                              ^
libiptc.c:2153:2: note: in expansion of macro 'CHECK'
  CHECK(*handle);
  ^~~~~
libiptc.c:193:13: note: expected 'struct xtc_handle *' but argument is
of type
'struct xtc_handle'
 static void do_check(struct xtc_handle *h, unsigned int line);
             ^~~~~~~~
libiptc.c: In function 'iptc_commit':
libiptc.c:194:62: error: incompatible type for argument 1 of 'do_check'
 #define CHECK(h) do { if (!getenv("IPTC_NO_CHECK")) do_check((h),
__LINE__); }
while(0)
                                                              ^
libiptc.c:2533:2: note: in expansion of macro 'CHECK'
  CHECK(*handle);
  ^~~~~
libiptc.c:193:13: note: expected 'struct xtc_handle *' but argument is
of type
'struct xtc_handle'
 static void do_check(struct xtc_handle *h, unsigned int line);
             ^~~~~~~~
libip4tc.c: At top level:
libiptc.c:193:13: warning: 'do_check' used but never defined
make[5]: *** [libip4tc.lo] Error 1

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180801/a7dd6dea/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1275

Florian Westphal <fw at strlen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fw at strlen.de
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Florian Westphal <fw at strlen.de> ---
Hasn't compiled since 2004 or so, lets just remove this.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20190916/63ff834b/attachment.html>