netfilter buglog - Feb 2018 - [Bug 1224] New: nft export json fails with successful return code

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

            Bug ID: 1224
           Summary: nft export json fails with successful return code
           Product: nftables
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: nft
          Assignee: pablo at netfilter.org
          Reporter: anthonyryan1 at gmail.com

I recently upgraded to nftables v0.8.2 and encountered a regression.

"nft export json" no longer works, it returns a success code (0), but
doens't
print any JSON data.

A git bisect determined this was introduced in commit
2fa54d8a49352bda44d3e25d1d7ba3531faf3303, and upon reading that commit, I
noticed the introduction of "nft export vm json" which does work as
expected.

I believe "nft export json" should either export json like it did
before this
commit, or return a non-zero code if this is the intended functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180206/8f464dfc/attachment-0001.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

Anthony Ryan <anthonyryan1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mayhs11saini at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180206/37560773/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

Anthony Ryan <anthonyryan1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anthonyryan1 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180206/afc981ac/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

Shyam Saini <mayhs11saini at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at nwl.cc

--- Comment #1 from Shyam Saini <mayhs11saini at gmail.com> ---
Hi Anthony,
> I recently upgraded to nftables v0.8.2 and encountered a regression.
> 
> "nft export json" no longer works, it returns a success code (0),
but
> doens't print any JSON data.
> 
> A git bisect determined this was introduced in commit
> 2fa54d8a49352bda44d3e25d1d7ba3531faf3303, and upon reading that commit, I
> noticed the introduction of "nft export vm json" which does work
as expected.
Technically when we were exporting json by "nft export json" it was
giving us
low level virtual-machine(vm) pseudo code. So we renamed it as "vm
json".
As you have already mentioned that you are able achieve old behaviour by 
"nft export vm json", that is right behaviour.

Further, by this renaming it creates scope for high level json which
represents abstract syntax tree of nft grammar. This high level json
can be exported by "nft export json". 
But this feature is yet to come in mainline so we are doing "no
operation" we
user executes "nft export json" and it returns 0.

> I believe "nft export json" should either export json like it did
before
> this commit, or return a non-zero code if this is the intended
functionality.
I hope above explanation clarifies this. 

I'm cc'ing Phil, he may put some light on high level json.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180206/dcc88e97/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180214/8b025b47/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1224

Anthony Ryan <anthonyryan1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Anthony Ryan <anthonyryan1 at gmail.com> ---
It's a reasonable explanation given the future plans, closing the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180216/c915a310/attachment.html>