netfilter buglog - Jan 2018 - [Bug 1209] New: Replace 'netstat' with 'ss'

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

            Bug ID: 1209
           Summary: Replace 'netstat' with 'ss'
           Product: ipset
           Version: unspecified
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: default
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: kstreitova at suse.com

Since the 'netstat' command is deprecated I suggest replacing it with
'ss'
command in tests/runtest.sh file.

I'm adding a simple patch:


Index: ipset-6.34/tests/runtest.sh
==================================================================---
ipset-6.34.orig/tests/runtest.sh
+++ ipset-6.34/tests/runtest.sh
@@ -45,7 +45,7 @@ add_tests() {
          `$cmd -t filter | grep ACCEPT | wc -l` -eq 3 ]; then
              if [ -z "`which sendip`" ]; then
                  echo "sendip utility is missig: skipping $1 match and
target
tests"
-             elif [ -n "`netstat --protocol $1 -n | grep $2`" ]; then
+             elif [ -n "`ss -f $1 -n | grep $2`" ]; then
                  echo "Our test network $2 in use: skipping $1 match and
target tests"
              else
                  tests="$tests $add"

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180102/db95deea/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

Kristyna Streitova <kstreitova at suse.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Replace 'netstat' with 'ss' |Replace
deprecated
                   |                            |'net-tools' commands

--- Comment #1 from Kristyna Streitova <kstreitova at suse.com> ---
Please note that similar problem is also e.g. in
utils/ipset_bash_completion/ipset file where the deprecated 'arp'
command is
used:

789 if ((y)); then
790     # read arp cache, addresses of local interfaces and /etc/ethers
791     str_tmp=$(while read a b addr rest; do
792         [[ $addr =~ $str_regex ]] && printf "%s\n"
"$addr"
793         done < <(PATH=$PATH:/sbin command arp -n 2>/dev/null))

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180103/df7b9ab4/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kadlec at netfilter.org

--- Comment #2 from Jozsef Kadlecsik <kadlec at netfilter.org> ---
"ss -f inet -n" returns not only tcp/udp sockets, but a lot of others
as well.

It'd be better to use "ss -t -u -a" instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180112/79fd43d8/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

--- Comment #3 from Jozsef Kadlecsik <kadlec at netfilter.org> ---
The bash completion tool is not written by me, see
https://github.com/AllKind/ipset-bash-completion

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180112/570ee4df/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

--- Comment #4 from Kristyna Streitova <kstreitova at suse.com> ---
(In reply to Jozsef Kadlecsik from comment #3)
> The bash completion tool is not written by me, see
> https://github.com/AllKind/ipset-bash-completion
Thank you for the notice, I will open an issue there.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180112/000ffb9b/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX
                 CC|                            |pablo at netfilter.org

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180202/1add1452/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

--- Comment #5 from Kristyna Streitova <kstreitova at suse.com> ---
It was closed as wontfix but it still needs to be addressed for
tests/runtest.sh. Or is there any reason for wontfix? Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180205/33e79dc5/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #6 from Pablo Neira Ayuso <pablo at netfilter.org> ---
My fault, I thought this change was needed only by third party software. I'm
reopening it and will leave it up to you to decide where to go.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180205/d51b377b/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1209

Jozsef Kadlecsik <kadlec at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #7 from Jozsef Kadlecsik <kadlec at netfilter.org> ---
I added ss to check the test network with a fallback to netstat in runtest.sh.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180303/8cacd213/attachment.html>