netfilter buglog - Dec 2017 - [Bug 1205] New: libnftl symbols not visible when built with clang

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

            Bug ID: 1205
           Summary: libnftl symbols not visible when built with clang
           Product: netfilter/iptables
           Version: unspecified
          Hardware: x86_64
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: unknown
          Assignee: netfilter-buglog at lists.netfilter.org
          Reporter: krejzi at email.com

I couldn't find a component for libnftnl, so I added the person who did last
couple of releases to CC. Please reassign as needed.

When building libnftl with clang, the following warnings are being output:

ruleset.c:611:1: warning: attribute declaration must precede definition
[-Wignored-attributes]
EXPORT_SYMBOL(nftnl_ruleset_parse_buffer_cb);

This results in libnftnl library without any exported symbols. A similar
problem was found and fixed in libmnl [1]. The patch is the same, and
there's
one for version libnftnl-1.0.7 [2] (doesn't apply to git master anymore)
which
makes libnftnl build cleanly and makes the required symbols visible again.

[1]
http://git.netfilter.org/libmnl/commit/?id=dcdb47373a375087d2dd8cee5e2a9c66fcc147eb
[2]
https://github.com/elkrejzi/pacman/blob/master/pkgbuild/libnftnl/libnftnl-fixes.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20171214/9c76ecea/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

Armin K. <krejzi at email.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pablo at netfilter.org

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20171214/f7c6d063/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Please, submit your patch to netfilter-devel at vger.kernel.org in
git-format-patch. Add a description and your Signed-off-by tag via -s option,
and I'll take it.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20171215/acc7c3f5/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

--- Comment #2 from Armin K. <krejzi at email.com> ---
I'm unable to send an email to the mentioned mailing list:

A message that you sent could not be delivered to one or more of its
recipients. This is a permanent error. The following address(es) failed:

netfilter-devel at vger.kernel.org:

SMTP error from remote server for MAIL FROM command, host: vger.kernel.org
(209.132.180.67) reason: 553 5.7.1 Hello [74.208.4.201], for your MAIL FROM
address <krejzi[AT]email.com> policy analysis reported: Your address is
not
liked source for email



I've added your mail address to CC, and I don't have any other email
address
that I can set up for this nor the time to bother getting one.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20171223/5ccc0af6/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

--- Comment #3 from Armin K. <krejzi at email.com> ---
Created attachment 514
  --> https://bugzilla.netfilter.org/attachment.cgi?id=514&action=edit
Fix exporting symbols with clang

Adding the patch here, for verification.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20171223/9489b504/attachment.html>

https://bugzilla.netfilter.org/show_bug.cgi?id=1205

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Pablo Neira Ayuso <pablo at netfilter.org> ---
Patch already upstream, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.netfilter.org/pipermail/netfilter-buglog/attachments/20180202/98fe87f9/attachment.html>