netfilter buglog - Nov 2013 - [Bug 872] New: extra symbols in console output

https://bugzilla.netfilter.org/show_bug.cgi?id=872

           Summary: extra symbols in console output
           Product: nftables
           Version: unspecified
          Platform: x86_64
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: nft
        AssignedTo: pablo at netfilter.org
        ReportedBy: loki at lokis-chaos.de
   Estimated Hours: 0.0


nft shows extra symbols. I could reproduce this at least for iifname.
The extra symbols are not shown if the output is not the tty:


fwtest01 ~ # nft -i
nft> table filter
nft> add chain filter input
nft> add rule filter input meta iifname "lo" accept
nft> list table filter
table ip filter {
        chain input {
                 meta iifname "lo?.?" accept
        }
}
nft> 
fwtest01 ~ # nft list table filter -n  -a
table ip filter {
        chain input {
                 meta iifname "lo?V" accept # handle 2
        }
}
fwtest01 ~ # nft list table filter -n  -a | cat 
table ip filter {
        chain input {
                 meta iifname "lo" accept # handle 2
        }
}


i have tried to backtrace the error, and it looks like an optimizer error in
string_type_print (datatype.c:262):
Breakpoint 1, string_type_print (expr=0x63cc90) at src/datatype.c:257
257     {
(gdb) p expr
$1 = (const struct expr *) 0x63cc90
(gdb) p expr->len
$2 = 16
(gdb) p expr->value
$3 = {{_mp_alloc = 2, _mp_size = 1, _mp_d = 0x63c7f0}}
(gdb) p BITS_PER_BYTE
No symbol "BITS_PER_BYTE" in current context.
(gdb) s
261             mpz_export_data(data, expr->value, BYTEORDER_HOST_ENDIAN,
len);
(gdb) p  len
$4 = <optimized out>

The nft util was compiled with gcc 4.6.3.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=872

Phil Oester <netfilter at linuxace.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |netfilter at linuxace.com

--- Comment #1 from Phil Oester <netfilter at linuxace.com> 2013-11-13
18:23:47 CET ---
Cannot reproduce this.  Are you sure you're using the latest git versions of
libnftables and nftables?  

# nft -i
nft> table filter
nft> add chain filter input
nft> add rule filter input meta iifname "lo" accept
nft> list table filter
table ip filter {
        chain input {
                 meta iifname "lo" accept
        }
}
nft>

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=872

--- Comment #2 from Thomas Berger <loki at lokis-chaos.de> 2013-11-13
19:08:14 CET ---
Our tree is up2date.

We could reproduce this error with every gcc version.

fwtest01 nftables # git pull
Already up-to-date.
fwtest01 nftables # gcc -v
Using built-in specs.
COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/4.7.3/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.7.3/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/paludis/sys-devel-gcc-4.7.3-r1/work/gcc-4.7.3/configure --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/4.7.3
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.3/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.7.3
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.7.3/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.7.3/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.7.3/include/g++-v4
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --disable-altivec
--disable-fixed-point --without-cloog --without-ppl --disable-lto --enable-nls
--without-included-gettext --with-system-zlib --enable-obsolete
--disable-werror --enable-secureplt --enable-multilib
--with-multilib-list=m32,m64 --enable-libmudflap --disable-libssp
--enable-libgomp
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/4.7.3/python
--enable-checking=release --disable-libgcj --enable-libstdcxx-time
--enable-languages=c,c++,fortran --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-targets=all
--with-bugurl=http://bugs.gentoo.org/ --with-pkgversion='Gentoo 4.7.3-r1
p1.3,
pie-0.5.5'
Thread model: posix
gcc version 4.7.3 (Gentoo 4.7.3-r1 p1.3, pie-0.5.5) 
fwtest01 nftables # uname -a
Linux fwtest01 3.12.0-gentoo #1 SMP Mon Nov 11 21:54:44 CET 2013 x86_64 AMD
Opteron(TM) Processor 6272 AuthenticAMD GNU/Linux

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=872

Pablo Neira Ayuso <pablo at netfilter.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Pablo Neira Ayuso <pablo at netfilter.org> 2013-11-25
11:21:33 CET ---
I have submitted a patch to address this issue:

http://patchwork.ozlabs.org/patch/293776/

I'd appreciate if you can give it a test and confirm that this resolves the
problem that you're noticing.

Thank you for reporting.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

https://bugzilla.netfilter.org/show_bug.cgi?id=872

Phil Oester <netfilter at linuxace.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Phil Oester <netfilter at linuxace.com> 2013-11-30
22:15:53 CET ---
Patch applied in commit 99af859adcf8 (datatype: fix missing nul-terminated
string in string_type_print).  Closing.

-- 
Configure bugmail: https://bugzilla.netfilter.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.