netfilter buglog - Jan 2007 - [Bug 532] ip_nat_sip rewrote Call-ID instead of Contact - patch attached

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=532


kaber@trash.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|laforge@netfilter.org       |kaber@trash.net




------- Additional Comments From kaber@trash.net  2007-01-26 19:45 MET -------
(In reply to comment #0)
> 
> The fix should be safe, even in the presence of clients that use
continuation
lines.

It it really? I think it will fail at something like this:

Contact:
  xyz@1.2.3.4

I guess it needs to check whether the next line starts with whitespace, no?

(BTW, please include a Signed-off-by: line).

-- 
Configure bugmail:
https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=532


kaber@trash.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|laforge@netfilter.org       |kaber@trash.net




------- Additional Comments From kaber@trash.net  2007-01-26 19:45 MET -------
(In reply to comment #0)
> 
> The fix should be safe, even in the presence of clients that use
continuation
lines.

It it really? I think it will fail at something like this:

Contact:
  xyz@1.2.3.4

I guess it needs to check whether the next line starts with whitespace, no?

(BTW, please include a Signed-off-by: line).

-- 
Configure bugmail:
https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=532


kaber@trash.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




-- 
Configure bugmail:
https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=532





------- Additional Comments From lars@ibp.de  2007-01-27 19:43 MET -------
(In reply to comment #1)
> (In reply to comment #0)
> > 
> > The fix should be safe, even in the presence of clients that use 
> > continuation lines.
> 
> It it really? I think it will fail at something like this:
> 
> Contact:
>   xyz@1.2.3.4
Yes, that would fail, but it's not a valid Contact header (the URI scheme is
missing). A Contact header like:

Contact:
    sip:xyz@1.2.3.4

would work, because the current code will scan for the "sip:".

This one would fail, but it's also invalid:

Contact: sip:
   xyz@1.2.3.4 
> (BTW, please include a Signed-off-by: line).
I am a newbie; thanks.

What about this:

When trying to skip over the username in the Contact header, stop at the
end of the line if no @ is found. We don't need to worry about continuation
lines, because we search inside a SIP URI.

X-Signed-off-by: Lars Immisch <lars@ibp.de>

--- ip_conntrack_sip.orig       2007-01-18 01:25:24.000000000 +0100
+++ ip_conntrack_sip.c  2007-01-27 18:31:38.000000000 +0100
@@ -247,7 +247,11 @@
 {
        int s = *shift;
 
-       for (; dptr <= limit && *dptr != '@'; dptr++)
+       // Search for @, but stop at the end of the line.
+       // We are inside a sip: URI, so we don't need to worry about 
+       // continuation lines.
+       for (; dptr <= limit && *dptr != '@' && 
+                        *dptr != '\r' && *dptr != '\n';
dptr++)
                (*shift)++;
 
        if (*dptr == '@') {

-- 
Configure bugmail:
https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

https://bugzilla.netfilter.org/bugzilla/show_bug.cgi?id=532


kaber@trash.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From kaber@trash.net  2007-01-28 02:25 MET -------
Queued (slightly reformatted) patch for 2.6.20.

-- 
Configure bugmail:
https://bugzilla.netfilter.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You reported the bug, or are watching the reporter.