Tilmann Singer
2008-Feb-05 14:57 UTC
[Mongrel] throttle wrongly treated as seconds instead of 100th of seconds?
Am I missing the reason why the value of @throttle is documented and at one point treated as hundreths of seconds, but at other points treated as full seconds? If this is just a bug then I propose the attached fix (tests still pass, but no test added explicitely for the fix). Til -- http://plazes.com/whereis/til | +49 176 20 19 51 69 | http://tils.net -------------- next part -------------- A non-text attachment was scrubbed... Name: throttle.patch Type: text/x-diff Size: 1079 bytes Desc: not available Url : http://rubyforge.org/pipermail/mongrel-users/attachments/20080205/0be41bd8/attachment.bin
Evan Weaver
2008-Feb-06 22:50 UTC
[Mongrel] throttle wrongly treated as seconds instead of 100th of seconds?
@throttle is supposed to be hundreds of seconds, but the docs might be out of date, because @throttle used to be called @timeout, and @timeout itself is new. If you still think it''s a bug please file a ticket on Rubyforge. Evan On Feb 5, 2008 9:57 AM, Tilmann Singer <tils at tils.net> wrote:> Am I missing the reason why the value of @throttle is documented and > at one point treated as hundreths of seconds, but at other points > treated as full seconds? If this is just a bug then I propose the > attached fix (tests still pass, but no test added explicitely for the > fix). > > > Til > > > > > -- > http://plazes.com/whereis/til | +49 176 20 19 51 69 | http://tils.net > > _______________________________________________ > Mongrel-users mailing list > Mongrel-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-users >-- Evan Weaver Cloudburst, LLC
Tilmann Singer
2008-Feb-06 23:05 UTC
[Mongrel] throttle wrongly treated as seconds instead of 100th of seconds?
* Evan Weaver <evan at cloudbur.st> [20080206 23:49]:> @throttle is supposed to be hundreds of seconds, but the docs might be > out of date, because @throttle used to be called @timeout, and > @timeout itself is new.The docs about @throttle are right, just in 2 places in the code @throttle is wrongly used as seconds. This bug was also there before the introduction of @timeout.> If you still think it''s a bug please file a ticket on Rubyforge.Will do. Til> Evan > > On Feb 5, 2008 9:57 AM, Tilmann Singer <tils at tils.net> wrote: > > Am I missing the reason why the value of @throttle is documented and > > at one point treated as hundreths of seconds, but at other points > > treated as full seconds? If this is just a bug then I propose the > > attached fix (tests still pass, but no test added explicitely for the > > fix). > > > > > > Til > > > > > > > > > > > > _______________________________________________ > > Mongrel-users mailing list > > Mongrel-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/mongrel-users > > > > >-- http://tsinger.com +49-176 20 19 51 69