Hey Evan and others watching this list. I would love to release an official small point release for Mongrel in the next couple of days. Mainly, the following things is what I''m aiming: * Basic Ruby 1.9 functionality This means "it just built and run", it doesn''t mean anything optimized for 1.9. Bigger versions can address those details. There is a weird Zlib error I''m going to investigate. * Modernize infrastructure - Latest Ruby versions do not require fastthread, since has been integrated by default (1.8.6 greater than p114) - CGI has been patched since 1.8.6-p114 I believe those 2 dependencies can be dropped, and required_ruby_version of Mongrel itself bumped to 1.8.6 instead of 1.8.5, since due our changes in API compatibility may not build. Also, I''ve invested a couple of months creating rake-compiler: http://github.com/luislavena/rake-compiler Not a shameless self-promotion, but it has been working great for other projects and also removed the need to depend or require a Windows building environment to be able to release Windows gems. Add to that the concept of "fat binaries", and you get lot of happy Windows users on Ruby 1.8 or 1.9 :-) * Faster release cycles. Let''s get serious. There was no release of Mongrel itself in the past YEAR. We all know Mongrel *is* stable, but things can get obsolete pretty easily in the software industry. I still use Mongrel on Windows for development and still deploy to Linux servers running it, or Windows intranets using mongrel_service. While some people had migrated to Passenger, there is still lot of value on Mongrel itself. So, ranting on a side, let''s take the advantage of Git and GitHub, provide a working stable branch/master and start looking at quality patches. That is the purpose of the branch "spinoff" available in my fork: http://github.com/luislavena/mongrel/tree/spinoff Things that are missing there: * Steps to build the Java gem rake-compiler hasn''t been extended to get Java extensions build, been waiting for some patches for that but no luck, so going to add a tasks/java.rake for now. * Ensure all tests pass, on all platforms. There are some weird tests that I just skipped on Windows, need further testing to see what is wrong with them, which is going to take me some time. Except from that and the 1.9 error described at the top of this email, everything passes on OSX and Linux. Something really weird I noticed is on threaded tests. They work differently with 1.8.6-p287 and 1.8.6-p368, I believe this is the main difference on the stalled tests. Going to do a multiruby pass and see the results (stay tuned). So, mainly, that is my reason for the spinoff branch, what do you guys think? Evan: I know you forked this branch, and committed some patches from mattetti, but while you see the value of those (specially one huge commit) I see a mess to trace back "what the heck" something was not working anymore. Let''s keep this conversation and see if we can address those issues. I have a few days off from work that I want to take advantage of. Cheers, -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry
I''ll bust up the mega-patch into discrete commits either today or Monday morning. What do you need re. Java? Just something in rake-compiler, or is there a problem in Mongrel? Did you already integrate the Ragel 6.5 fixes? Evan On Wed, Jul 8, 2009 at 5:23 AM, Luis Lavena<luislavena at gmail.com> wrote:> Hey Evan and others watching this list. > > I would love to release an official small point release for Mongrel in > the next couple of days. Mainly, the following things is what I''m > aiming: > > * Basic Ruby 1.9 functionality > > This means "it just built and run", it doesn''t mean anything optimized > for 1.9. Bigger versions can address those details. > > There is a weird Zlib error I''m going to investigate. > > * Modernize infrastructure > > - Latest Ruby versions do not require fastthread, since has been > integrated by default (1.8.6 greater than p114) > - CGI has been patched since 1.8.6-p114 > > I believe those 2 dependencies can be dropped, and > required_ruby_version of Mongrel itself bumped to 1.8.6 instead of > 1.8.5, since due our changes in API compatibility may not build. > > Also, I''ve invested a couple of months creating rake-compiler: > > http://github.com/luislavena/rake-compiler > > Not a shameless self-promotion, but it has been working great for > other projects and also removed the need to depend or require a > Windows building environment to be able to release Windows gems. > > Add to that the concept of "fat binaries", and you get lot of happy > Windows users on Ruby 1.8 or 1.9 :-) > > * Faster release cycles. > > Let''s get serious. There was no release of Mongrel itself in the past > YEAR. We all know Mongrel *is* stable, but things can get obsolete > pretty easily in the software industry. > > I still use Mongrel on Windows for development and still deploy to > Linux servers running it, or Windows intranets using mongrel_service. > > While some people had migrated to Passenger, there is still lot of > value on Mongrel itself. > > So, ranting on a side, let''s take the advantage of Git and GitHub, > provide a working stable branch/master and start looking at quality > patches. > > That is the purpose of the branch "spinoff" available in my fork: > > http://github.com/luislavena/mongrel/tree/spinoff > > Things that are missing there: > > * Steps to build the Java gem > > rake-compiler hasn''t been extended to get Java extensions build, been > waiting for some patches for that but no luck, so going to add a > tasks/java.rake for now. > > * Ensure all tests pass, on all platforms. > > There are some weird tests that I just skipped on Windows, need > further testing to see what is wrong with them, which is going to take > me some time. > Except from that and the 1.9 error described at the top of this email, > everything passes on OSX and Linux. > > Something really weird I noticed is on threaded tests. They work > differently with 1.8.6-p287 and 1.8.6-p368, I believe this is the main > difference on the stalled tests. > > Going to do a multiruby pass and see the results (stay tuned). > > So, mainly, that is my reason for the spinoff branch, what do you guys think? > > Evan: I know you forked this branch, and committed some patches from > mattetti, but while you see the value of those (specially one huge > commit) I see a mess to trace back "what the heck" something was not > working anymore. > > Let''s keep this conversation and see if we can address those issues. I > have a few days off from work that I want to take advantage of. > > Cheers, > -- > Luis Lavena > AREA 17 > - > Perfection in design is achieved not when there is nothing more to add, > but rather when there is nothing more to take away. > Antoine de Saint-Exup?ry > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development >-- Evan Weaver
On Wed, Jul 8, 2009 at 12:35 PM, Evan Weaver<evan at cloudbur.st> wrote:> I''ll bust up the mega-patch into discrete commits either today or > Monday morning.Thank you. I know is a PITA, but really like to know what we are delivering with this new release. After assessing all the changes from History.txt, we can decide if it is forth a small point release or we bump the minor counter.> What do you need re. Java? Just something in rake-compiler, or is > there a problem in Mongrel? >I''m going to see if the java task can be executed from MRI or from JRuby, and better organize those in its own rakefile. Since I''m not a Java expert, will leave the integration with rake-compiler for later :-)> Did you already integrate the Ragel 6.5 fixes? >The fix I''ve in the spinoff branch already compile and build with latest Ragel, so guess everything is good there. Will double check just in case.> Evan >Thank you man and have a nice week. -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry
Luis Lavena <luislavena at gmail.com> wrote:> * Faster release cycles. > > Let''s get serious. There was no release of Mongrel itself in the past > YEAR. We all know Mongrel *is* stable, but things can get obsolete > pretty easily in the software industry. > > I still use Mongrel on Windows for development and still deploy to > Linux servers running it, or Windows intranets using mongrel_service. > > While some people had migrated to Passenger, there is still lot of > value on Mongrel itself.Just another data point, some applications I deal with has been using the latest Mongrel SVN trunk revisions for well over a year now. Heck, it works even so well that nobody (besides myself) is even remotely interested in even trying them on anything else. -- Eric Wong
Hmm...SVN trunk has the monster patch applied, but in individual commits. :-) I used git-svn and added it to http://github.com/fauna/mongrel/tree/trunk_from_svn, where it can lie unchanged for reference. Evan On Wed, Jul 8, 2009 at 2:03 PM, Eric Wong<normalperson at yhbt.net> wrote:> Luis Lavena <luislavena at gmail.com> wrote: >> * Faster release cycles. >> >> Let''s get serious. There was no release of Mongrel itself in the past >> YEAR. We all know Mongrel *is* stable, but things can get obsolete >> pretty easily in the software industry. >> >> I still use Mongrel on Windows for development and still deploy to >> Linux servers running it, or Windows intranets using mongrel_service. >> >> While some people had migrated to Passenger, there is still lot of >> value on Mongrel itself. > > Just another data point, some applications I deal with has been using > the latest Mongrel SVN trunk revisions for well over a year now. ?Heck, > it works even so well that nobody (besides myself) is even remotely > interested in even trying them on anything else. > > -- > Eric Wong > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development >-- Evan Weaver
On Wed, Jul 8, 2009 at 7:00 PM, Evan Weaver<evan at cloudbur.st> wrote:> Hmm...SVN trunk has the monster patch applied, but in individual commits. :-) > > I used git-svn and added it to > http://github.com/fauna/mongrel/tree/trunk_from_svn, where it can lie > unchanged for reference. >Awesome! thank you man, going to take a look tomorrow. -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry
Luis, how''s it going so far? Evan On Wed, Jul 8, 2009 at 3:37 PM, Luis Lavena<luislavena at gmail.com> wrote:> On Wed, Jul 8, 2009 at 7:00 PM, Evan Weaver<evan at cloudbur.st> wrote: >> Hmm...SVN trunk has the monster patch applied, but in individual commits. :-) >> >> I used git-svn and added it to >> http://github.com/fauna/mongrel/tree/trunk_from_svn, where it can lie >> unchanged for reference. >> > > Awesome! thank you man, going to take a look tomorrow. > -- > Luis Lavena > AREA 17 > - > Perfection in design is achieved not when there is nothing more to add, > but rather when there is nothing more to take away. > Antoine de Saint-Exup?ry > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development >-- Evan Weaver
On Mon, Jul 13, 2009 at 7:34 PM, Evan Weaver<evan at cloudbur.st> wrote:> Luis, how''s it going so far? >Lot of commits to review, will push to spinoff branch the upcoming days (returned to work today and lot to catchup after 1 week off). -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry
Want me to work on this? I have some time this week. Evan On Mon, Jul 13, 2009 at 9:13 PM, Luis Lavena<luislavena at gmail.com> wrote:> On Mon, Jul 13, 2009 at 7:34 PM, Evan Weaver<evan at cloudbur.st> wrote: >> Luis, how''s it going so far? >> > > Lot of commits to review, will push to spinoff branch the upcoming > days (returned to work today and lot to catchup after 1 week off). > > -- > Luis Lavena > AREA 17 > - > Perfection in design is achieved not when there is nothing more to add, > but rather when there is nothing more to take away. > Antoine de Saint-Exup?ry > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development >-- Evan Weaver
Hey guys. At EY, we have a minor fork of Mongrel that we are carrying around which has a couple features that would be nice to see pulled back into the main line of Mongrel. Key changes for our minor fork is that it drops the pid file immediately after daemonizing, and it returns a proper 400 response if the HTTP parser encounters bad HTTP, which lets it play more nicely with proxies. Would you guys like patches for these two little changes? Kirk Haines
Yes please (at least for me). Evan On Mon, Jul 20, 2009 at 1:52 PM, Kirk Haines<wyhaines at gmail.com> wrote:> Hey guys. At EY, we have a minor fork of Mongrel that we are carrying > around which has a couple features that would be nice to see pulled > back into the main line of Mongrel. ?Key changes for our minor fork is > that it drops the pid file immediately after daemonizing, and it > returns a proper 400 response if the HTTP parser encounters bad HTTP, > which lets it play more nicely with proxies. > > Would you guys like patches for these two little changes? > > > Kirk Haines > _______________________________________________ > Mongrel-development mailing list > Mongrel-development at rubyforge.org > http://rubyforge.org/mailman/listinfo/mongrel-development >-- Evan Weaver
On Mon, Jul 20, 2009 at 5:52 PM, Kirk Haines<wyhaines at gmail.com> wrote:> Hey guys. At EY, we have a minor fork of Mongrel that we are carrying > around which has a couple features that would be nice to see pulled > back into the main line of Mongrel. ?Key changes for our minor fork is > that it drops the pid file immediately after daemonizing, and it > returns a proper 400 response if the HTTP parser encounters bad HTTP, > which lets it play more nicely with proxies. > > Would you guys like patches for these two little changes? >Yes please, since EY mongrel fork didn''t start from fauna''s one -- so is not showing at GitHub network. -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exup?ry