Masterview devel - Feb 2007 - Review comments on admin page custom authorization

p.s. do you want me to make a revision pass per my comments or do you want
to do that (assuming you agree with what I suggested, that is!)

This does seem like the right approach, in general - I can write a normal
method in the normal way w/out worrying about access constraints from a
block.

Other variation might be for app developer to supply just the text of the
allow_access? predicate method, which we''d then compile into the
MasterViewController (similar to dynamically generated method installation),
but that seems a bit odd - I like it better to write a proper, legit ruby
module used as a mixin.

~ Deb

On 2/8/07, Deb Lewis <djlewis at acm.org> wrote:
>
> p.s. do you want me to make a revision pass per my comments or do you want
> to do that (assuming you agree with what I suggested, that is!)
>
> This does seem like the right approach, in general - I can write a normal
> method in the normal way w/out worrying about access constraints from a
> block.
>
> Other variation might be for app developer to supply just the text of the
> allow_access? predicate method, which we''d then compile into the
> MasterViewController (similar to dynamically generated method
> installation),
> but that seems a bit odd - I like it better to write a proper, legit ruby
> module used as a mixin.
>
>
Yes, I agree with your comments. If you have time to fix this up like you
mentioned that would be great!!

And I do think that we would have to have something in the
masterview_controller (but could be one liner) to do the mixin since
controllers get dropped and reloaded in development mode, so we are not
necessarily going to be able to hook it from elsewhere and guarantee that it
is rehooked if reloaded later.

Thanks,

Jeff
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20070208/7bd242b3/attachment.html