Jeff Barczewski
2006-Oct-29 22:44 UTC
[Masterview-devel] Commited xmldecl and doctype fix - added custom patched REXML classes
I have committed the xmldecl (version and encoding) and doctype fix so that MasterView will output those if they are supplied in the template. In fixing the doctype issue, I discovered that the sax2 parser in REXML was not triggering the doctype event. Checking the code confirmed this as well as the missing test case. I pulled the latest REXML code version 3.1.5, created a couple test cases and a fix for the doctype issue. I submitted them to the REXML trac site with the patch for all of the above. Since REXML is normally shipped with Ruby, it is likely that our users will have a broken version for quite some time. So using the patched code I created our own custom sax2 parser called Sax2ParserWithDoctypeFix and baseparser BaseParserWithDoctypeFix so that MasterView can use the patched code immediately. Once REXML applies the patch I sent them and we can determine a release number for it, then we can conditionally use these classes or the core REXML classes (if user has the lastest version). For right now I always use the patched classes until we can determine a version to check. These two patched classes live in masterview/lib/rexml/parsers Since we have created our own classes we will not interfere with anyone using the core classes. The REXML bug fix ticket is 92 http://www.germane-software.com/projects/rexml/ticket/92 Jeff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20061029/0ae77ec0/attachment.html