Masterview devel - Oct 2006 - Code review: adding parens in generated output erb

I think the resulting expressions using paren''d function notation is
fine.

But.. it''s a bit odd to see "if( foo )" and "elseif( bar
)" without a space,
though it does seem to parse correctly.  Dunno if it''s worth adding a
special-case check for conditional keywords vs. function name in
prepare_output.

~ Deb

Great.

Well personally when I use the parens with conditionals I usually do
it without the space (like it is), but we can do something special if
you think it is necessary, otherwise I think simple is good.

Jeff

On 10/17/06, Deb Lewis <djlewis at acm.org> wrote:
> I think the resulting expressions using paren''d function notation
is fine.
>
> But.. it''s a bit odd to see "if( foo )" and
"elseif( bar )" without a space,
> though it does seem to parse correctly.  Dunno if it''s worth
adding a
> special-case check for conditional keywords vs. function name in
> prepare_output.
>
> ~ Deb
>
>
> _______________________________________________
> Masterview-devel mailing list
> Masterview-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/masterview-devel
>

>>> personally when I use the parens with conditionals 
>> I usually do it without the space (like it is)
reeaally???? wow, ok then. I never do and questioned whether it was even
syntactically legal when I saw that notation in the test cases.

as long as it compiles and executes correctly, leave it be.

~ Deb