Masterview devel - Jul 2006 - Want to revise how you did enabling admin view in dev only

Jeff - you did this change in a way that''s a bit diff from all our
other
config setting defaults (turned on only in the
masterview/environments/development.rb rather than installing default in
Configuration#initialize) and I''d like to redo to make the
implementation
consistent.

Believe you were trying to maintain compatibility between 0.2.0 when we
introduced the new config mechanism, when enable-admin was always off, and
0.2.3 when we changed the default to on for dev, but I think in this case
you''re working too hard at compat.  

This is a benign change, worst case is that someone who really doesn''t
want
this in their dev setup just needs to go explicitly turn that off again.

There''ll unquestionably be cases in the future when doing some fiddling
in
the implementation and deviating from the standard approach in how things
are done is worth doing to provide upward compat, but I don''t think in
this
case it''s justified. 

~ Deb

Sounds fine Deb, I guess I wasn''t sure the best way to do this, but if
you
want to fix it up, then I''ll take note of how I should have made the
change
for consistency. I didn''t realize we had any other development defaults
in
the system, so that''s why I made the change the way I did. If you
already
had a plan and way to handle that, then I think we should use your approach.

On 7/4/06, Deb Lewis <djlewis at acm.org> wrote:
>
> Jeff - you did this change in a way that''s a bit diff from all our
other
> config setting defaults (turned on only in the
> masterview/environments/development.rb rather than installing default in
> Configuration#initialize) and I''d like to redo to make the
implementation
> consistent.
>
> Believe you were trying to maintain compatibility between 0.2.0 when we
> introduced the new config mechanism, when enable-admin was always off, and
> 0.2.3 when we changed the default to on for dev, but I think in this case
> you''re working too hard at compat.
>
> This is a benign change, worst case is that someone who really
doesn''t
> want
> this in their dev setup just needs to go explicitly turn that off again.
>
> There''ll unquestionably be cases in the future when doing some
fiddling in
> the implementation and deviating from the standard approach in how things
> are done is worth doing to provide upward compat, but I don''t
think in
> this
> case it''s justified.
>
> ~ Deb
>
>
> _______________________________________________
> Masterview-devel mailing list
> Masterview-devel at rubyforge.org
> http://rubyforge.org/mailman/listinfo/masterview-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://rubyforge.org/pipermail/masterview-devel/attachments/20060705/b430ccf8/attachment.html