Hi,
I have switched from Mapstraction 1 to 2 for my project
''Zoph''. One of
the few things that don''t work is anything involving Events when
I''m
using Openlayers.
I have created the following simple example:
<div style="float: left; width: 450px; height: 600px;"
id="map"></div>
<div style="float: left; width: 450px; height: 600px;"
id="map2"></div>
<script type="text/javascript">
var mapstraction = new
mxn.Mapstraction(''map'',''openlayers'');
var mapstraction2 = new
mxn.Mapstraction(''map2'',''googlev3'');
mapstraction.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9);
mapstraction.endPan.addHandler(
function() { alert("You panner!"); }
);
mapstraction.click.addHandler(
function() { alert("You clicker!"); }
);
mapstraction2.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9);
mapstraction2.endPan.addHandler(
function() { alert("You panner!"); }
);
mapstraction2.click.addHandler(
function() { alert("You clicker!"); }
);
</script>
As you can see the calls for both are identical, still I get two maps,
but only the Google map shows the alerts. (Except for that, the
Openlayers map works).
Any ideas?
Jeroen
--
Zoph Organizes Photos!
http://www.zoph.org
Hi Jeroen, click event is not currently implemented with openlayers api... I''ll take look to implement this on of these days. ++ b_b Le 12/11/2010 15:59, Jeroen Roos a ?crit :> Hi, > > I have switched from Mapstraction 1 to 2 for my project ''Zoph''. One of > the few things that don''t work is anything involving Events when I''m > using Openlayers. > > I have created the following simple example: > > <div style="float: left; width: 450px; height: 600px;" id="map"></div> > <div style="float: left; width: 450px; height: 600px;" id="map2"></div> > <script type="text/javascript"> > var mapstraction = new mxn.Mapstraction(''map'',''openlayers''); > var mapstraction2 = new mxn.Mapstraction(''map2'',''googlev3''); > mapstraction.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9); > mapstraction.endPan.addHandler( > function() { alert("You panner!"); } > ); > mapstraction.click.addHandler( > function() { alert("You clicker!"); } > ); > > mapstraction2.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9); > mapstraction2.endPan.addHandler( > function() { alert("You panner!"); } > ); > mapstraction2.click.addHandler( > function() { alert("You clicker!"); } > ); > </script> > > As you can see the calls for both are identical, still I get two maps, > but only the Google map shows the alerts. (Except for that, the > Openlayers map works). > > Any ideas? > Jeroen
Hi Jeroen, Pull request is here : https://github.com/mapstraction/mxn/pull/44 Have to wait this one been accepted. ++ b_b Le 13/11/2010 14:09, bruno bergot a ?crit :> Hi Jeroen, > > click event is not currently implemented with openlayers api... > > I''ll take look to implement this on of these days. > > ++ > b_b > > Le 12/11/2010 15:59, Jeroen Roos a ?crit : >> Hi, >> >> I have switched from Mapstraction 1 to 2 for my project ''Zoph''. One of >> the few things that don''t work is anything involving Events when I''m >> using Openlayers. >> >> I have created the following simple example: >> >> <div style="float: left; width: 450px; height: 600px;" id="map"></div> >> <div style="float: left; width: 450px; height: 600px;" id="map2"></div> >> <script type="text/javascript"> >> var mapstraction = new mxn.Mapstraction(''map'',''openlayers''); >> var mapstraction2 = new mxn.Mapstraction(''map2'',''googlev3''); >> mapstraction.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9); >> mapstraction.endPan.addHandler( >> function() { alert("You panner!"); } >> ); >> mapstraction.click.addHandler( >> function() { alert("You clicker!"); } >> ); >> >> mapstraction2.setCenterAndZoom(new mxn.LatLonPoint(52,4), 9); >> mapstraction2.endPan.addHandler( >> function() { alert("You panner!"); } >> ); >> mapstraction2.click.addHandler( >> function() { alert("You clicker!"); } >> ); >> </script> >> >> As you can see the calls for both are identical, still I get two maps, >> but only the Google map shows the alerts. (Except for that, the >> Openlayers map works). >> >> Any ideas? >> Jeroen
Apologies, my internet connection has been down at home since Friday. Haven''t been able to process any pull requests and I''m not sure when it will be back up. Could be a while but I''ll try my best. Derek On 14 Nov 2010 17:09, "bruno bergot" <brunobergot at gmail.com> wrote: Hi Jeroen, Pull request is here : https://github.com/mapstraction/mxn/pull/44 Have to wait this one been accepted. ++ b_b Le 13/11/2010 14:09, bruno bergot a ?crit :> > Hi Jeroen, > > click event is not currently implemented with openlayers api... > > I''ll take lo...-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20101115/b4795644/attachment.htm>
Hi Derke, no problem, i''ve recreated the pull request because yesterday''s github crash deleted this one... ++ b_b Le 15/11/2010 09:56, Derek Fowler a ?crit :> Apologies, my internet connection has been down at home since Friday. > Haven''t been able to process any pull requests and I''m not sure when it will > be back up. Could be a while but I''ll try my best. > > Derek > > On 14 Nov 2010 17:09, "bruno bergot"<brunobergot at gmail.com> wrote: > > Hi Jeroen, > > Pull request is here : https://github.com/mapstraction/mxn/pull/44 > > Have to wait this one been accepted. > > ++ > b_b > > Le 13/11/2010 14:09, bruno bergot a ?crit : > > >> >> Hi Jeroen, >> >> click event is not currently implemented with openlayers api... >> >> I''ll take lo... > > > > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com
Okay, the events are merged in, grab 2.0.14 here: https://github.com/mapstraction/mxn/downloads <https://github.com/mapstraction/mxn/downloads>Still a ton of layer stuff from Bruno in the pull queue - seem to be tons of duplicates so I''m going to have to see what''s going on there and work out which ones should be coming in. Derek On 15 November 2010 15:27, bruno bergot <brunobergot at gmail.com> wrote:> Hi Derke, no problem, i''ve recreated the pull request because yesterday''s > github crash deleted this one... > > ++ > b_b > > Le 15/11/2010 09:56, Derek Fowler a ?crit : > >> Apologies, my internet connection has been down at home since Friday. >> Haven''t been able to process any pull requests and I''m not sure when it >> will >> be back up. Could be a while but I''ll try my best. >> >> Derek >> >> On 14 Nov 2010 17:09, "bruno bergot"<brunobergot at gmail.com> wrote: >> >> Hi Jeroen, >> >> Pull request is here : https://github.com/mapstraction/mxn/pull/44 >> >> Have to wait this one been accepted. >> >> ++ >> b_b >> >> Le 13/11/2010 14:09, bruno bergot a ?crit : >> >> >> >>> Hi Jeroen, >>> >>> click event is not currently implemented with openlayers api... >>> >>> I''ll take lo... >>> >> >> >> >> _______________________________________________ >> Mapstraction mailing list >> Mapstraction at lists.mapstraction.com >> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >> > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >-- Derek Fowler m. +44 (0) 7966 512 369 e. dezfowler at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20101119/97c9cb75/attachment.htm>
Hi Derek, Le 19/11/2010 01:58, Derek Fowler a ?crit :> Okay, the events are merged in, grab 2.0.14 here: > > https://github.com/mapstraction/mxn/downloadsGreat news :) One question : are you sure you have used a real git merge to report my changes to mapstraction ? It doesn''t seem when i look to my graph on github : https://github.com/brunob/mxn/network It seems that you have re commited my changes and added me as co-author of theses commits. Am i right ? (sorry i''m a newbee with git, i generally work with svn repos).> > <https://github.com/mapstraction/mxn/downloads>Still a ton of layer stuff > from Bruno in the pull queue - seem to be tons of duplicates so I''m going to > have to see what''s going on there and work out which ones should be coming > in.What kind of duplicates ? I''ve made a branch for any new funtionnality, so i have : -* openlayers_mapevents (this one have been "merged" in mapstraction so i will close it) -* googlev3_tilelayer = addTileLayer() and toggleTileLayer() for googlev3 -* openlayers_addimageoverlay = addImageOverlay() for openlayers -* openlayers_addoverlay = addOverlay() implementation for openlayers -* openlayers_addtilelayer = addTileLayer() implementation for openlayers I will close the "Openlayers mapevents" pull request has it had been merged. ++ b_b
Erm - no idea. I''m new at this git lark too. I did make changes myself and then push all the commits up including yours. I''m applying changes to an integration branch but I possibly need to do a merge from that branch into my master rather than just pulling from that branch into my master. I''ll try that with the next lot and see how it goes. If anyone on the list has experience of the correct procedure I''d appreciate some guidance. Cheers, Derek On 19 November 2010 10:19, bruno bergot <brunobergot at gmail.com> wrote:> Hi Derek, > > Le 19/11/2010 01:58, Derek Fowler a ?crit : > > Okay, the events are merged in, grab 2.0.14 here: >> >> https://github.com/mapstraction/mxn/downloads >> > > Great news :) One question : are you sure you have used a real git merge to > report my changes to mapstraction ? It doesn''t seem when i look to my graph > on github : > > https://github.com/brunob/mxn/network > > It seems that you have re commited my changes and added me as co-author of > theses commits. Am i right ? (sorry i''m a newbee with git, i generally work > with svn repos). > > > >> <https://github.com/mapstraction/mxn/downloads>Still a ton of layer stuff >> from Bruno in the pull queue - seem to be tons of duplicates so I''m going >> to >> have to see what''s going on there and work out which ones should be coming >> in. >> > > What kind of duplicates ? I''ve made a branch for any new funtionnality, so > i have : > > -* openlayers_mapevents (this one have been "merged" in mapstraction so i > will close it) > -* googlev3_tilelayer = addTileLayer() and toggleTileLayer() for googlev3 > -* openlayers_addimageoverlay = addImageOverlay() for openlayers > -* openlayers_addoverlay = addOverlay() implementation for openlayers > -* openlayers_addtilelayer = addTileLayer() implementation for openlayers > > I will close the "Openlayers mapevents" pull request has it had been > merged. > > ++ > b_b > > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >-- Derek Fowler m. +44 (0) 7966 512 369 e. dezfowler at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20101119/9decc332/attachment.htm>
Hi Derek, This help page explain how to merge a pull request : http://help.github.com/pull-requests/#merging_a_pull_request ++ b_b Le 19/11/2010 13:56, Derek Fowler a ?crit :> Erm - no idea. I''m new at this git lark too. > > I did make changes myself and then push all the commits up including yours. > > I''m applying changes to an integration branch but I possibly need to do a > merge from that branch into my master rather than just pulling from that > branch into my master. > > I''ll try that with the next lot and see how it goes. > > If anyone on the list has experience of the correct procedure I''d appreciate > some guidance. > > Cheers, > Derek >