Hi folks, Nice to see the progress of Mapstraction v2! I''m the co-maintainer of the Mapstraction module for Drupal [1] and is currently implementing more features to the module, from the Mapstraction API. Here is one question I have: Would it be possible to not have ''setInfoDiv'' override the value set in ''setInfoBubble''? It would be coolt to be able to show different things in the bubble and in the info div. I''m a PHP-developer and have only worked with mapstraction.js on the API level. I haven''t looked too deep into the code base, yet. Sorry for that. Keep up the good work! [1]: http://drupal.org/project/mapstraction -- Best regards, Dick "dixon_" Olsson Phone: +46733715039 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090610/c0a3f6b3/attachment.htm>
Hi Dick, The infoDiv and infoBubble text is stored separately, so it means that it''s *possible* to do what you''re asking. To me, it makes sense to keep bubble and infodiv text separate, but I''m not sure about the reasons behind the way it is currently implemented. I''d be interested to get the opinions of others here, especially those who may have made a decision about this in the past. I can''t find anything in the mailing list archives. --Adam --- Adam DuVander I like maps: http://mapscripting.com I like simple: http://adamduvander.com On Jun 10, 2009, at 2:06 PM, Dick Olsson wrote:> Hi folks, > > Nice to see the progress of Mapstraction v2! > > I''m the co-maintainer of the Mapstraction module for Drupal [1] and > is currently implementing more features to the module, from the > Mapstraction API. > > Here is one question I have: > > Would it be possible to not have ''setInfoDiv'' override the value set > in ''setInfoBubble''? It would be coolt to be able to show different > things in the bubble and in the info div. > > I''m a PHP-developer and have only worked with mapstraction.js on the > API level. I haven''t looked too deep into the code base, yet. Sorry > for that. > > Keep up the good work! > > [1]: http://drupal.org/project/mapstraction > > -- > > Best regards, > > Dick "dixon_" Olsson > Phone: +46733715039 > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com
Sorry - I replied to Dick without doing a Reply All. There are only a few providers for whom this is implemented and there''s a bug in those implementations that''s been copied from one provider to another. As a refinement for v2 this could be implemented in Mapstraction itself which would save quite a bit of provider code and make the coverage complete. I''ve attached a quick untested "fix" as a patch file. Don''t have time to test it right now (is 00:34 here) and I don''t have write access to the v1 SVN repository anyway. Cheers, Derek On Thu, Jun 11, 2009 at 12:10 AM, Adam DuVander <mapstraction at duvander.com>wrote:> Hi Dick, > > The infoDiv and infoBubble text is stored separately, so it means that it''s > *possible* to do what you''re asking. > > To me, it makes sense to keep bubble and infodiv text separate, but I''m not > sure about the reasons behind the way it is currently implemented. I''d be > interested to get the opinions of others here, especially those who may have > made a decision about this in the past. I can''t find anything in the mailing > list archives. > > --Adam > --- > Adam DuVander > I like maps: http://mapscripting.com > I like simple: http://adamduvander.com > > > On Jun 10, 2009, at 2:06 PM, Dick Olsson wrote: > > Hi folks, >> >> Nice to see the progress of Mapstraction v2! >> >> I''m the co-maintainer of the Mapstraction module for Drupal [1] and is >> currently implementing more features to the module, from the Mapstraction >> API. >> >> Here is one question I have: >> >> Would it be possible to not have ''setInfoDiv'' override the value set in >> ''setInfoBubble''? It would be coolt to be able to show different things in >> the bubble and in the info div. >> >> I''m a PHP-developer and have only worked with mapstraction.js on the API >> level. I haven''t looked too deep into the code base, yet. Sorry for that. >> >> Keep up the good work! >> >> [1]: http://drupal.org/project/mapstraction >> >> -- >> >> Best regards, >> >> Dick "dixon_" Olsson >> Phone: +46733715039 >> _______________________________________________ >> Mapstraction mailing list >> Mapstraction at lists.mapstraction.com >> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >> > > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >-- Derek Fowler m. +44 (0) 7966 512 369 e. dezfowler at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090611/8c2c5537/attachment-0001.htm> -------------- next part -------------- A non-text attachment was scrubbed... Name: info-div-issue.patch Type: application/octet-stream Size: 354844 bytes Desc: not available URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090611/8c2c5537/attachment-0001.obj>
Thanks all for quick responses! Yeah, as Adam said, I think it makes sense to keep info bubble and info div separate. I also think it would make sense to be able to invoke them on different marker events. Let''s say I only display a minimal info bubble on hover and complete info in the div on click. That would be cool to see, at least in v2 :) Shall I create a ticket on this in the issue queue? -- Best regards, Dick Olsson Phone: +46733715039 On Thu, Jun 11, 2009 at 1:35 AM, Derek Fowler <dezfowler at gmail.com> wrote:> Sorry - I replied to Dick without doing a Reply All. > There are only a few providers for whom this is implemented and there''s a > bug in those implementations that''s been copied from one provider to > another. As a refinement for v2 this could be implemented in Mapstraction > itself which would save quite a bit of provider code and make the coverage > complete. > > I''ve attached a quick untested "fix" as a patch file. Don''t have time to > test it right now (is 00:34 here) and I don''t have write access to the v1 > SVN repository anyway. > > Cheers, > Derek > > > On Thu, Jun 11, 2009 at 12:10 AM, Adam DuVander <mapstraction at duvander.com > > wrote: > >> Hi Dick, >> >> The infoDiv and infoBubble text is stored separately, so it means that >> it''s *possible* to do what you''re asking. >> >> To me, it makes sense to keep bubble and infodiv text separate, but I''m >> not sure about the reasons behind the way it is currently implemented. I''d >> be interested to get the opinions of others here, especially those who may >> have made a decision about this in the past. I can''t find anything in the >> mailing list archives. >> >> --Adam >> --- >> Adam DuVander >> I like maps: http://mapscripting.com >> I like simple: http://adamduvander.com >> >> >> On Jun 10, 2009, at 2:06 PM, Dick Olsson wrote: >> >> Hi folks, >>> >>> Nice to see the progress of Mapstraction v2! >>> >>> I''m the co-maintainer of the Mapstraction module for Drupal [1] and is >>> currently implementing more features to the module, from the Mapstraction >>> API. >>> >>> Here is one question I have: >>> >>> Would it be possible to not have ''setInfoDiv'' override the value set in >>> ''setInfoBubble''? It would be coolt to be able to show different things in >>> the bubble and in the info div. >>> >>> I''m a PHP-developer and have only worked with mapstraction.js on the API >>> level. I haven''t looked too deep into the code base, yet. Sorry for that. >>> >>> Keep up the good work! >>> >>> [1]: http://drupal.org/project/mapstraction >>> >>> -- >>> >>> Best regards, >>> >>> Dick "dixon_" Olsson >>> Phone: +46733715039 >>> _______________________________________________ >>> Mapstraction mailing list >>> Mapstraction at lists.mapstraction.com >>> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >>> >> >> _______________________________________________ >> Mapstraction mailing list >> Mapstraction at lists.mapstraction.com >> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >> > > > > -- > Derek Fowler > m. +44 (0) 7966 512 369 > e. dezfowler at gmail.com >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090611/96dd3f8f/attachment-0001.htm>
I emailed a patch fixing this issue to the list last night but I''ve just realised it got caught up by the list admin and needs to be "moderated". Am just sending Andrew a quick mail to see if he can push it through. Derek On Thu, Jun 11, 2009 at 9:06 AM, Dick Olsson <info at senzilla.com> wrote:> Thanks all for quick responses! > > Yeah, as Adam said, I think it makes sense to keep info bubble and info div > separate. I also think it would make sense to be able to invoke them on > different marker events. Let''s say I only display a minimal info bubble on > hover and complete info in the div on click. That would be cool to see, at > least in v2 :) > > Shall I create a ticket on this in the issue queue? > > -- > > Best regards, > > Dick Olsson > Phone: +46733715039 > > > On Thu, Jun 11, 2009 at 1:35 AM, Derek Fowler <dezfowler at gmail.com> wrote: > >> Sorry - I replied to Dick without doing a Reply All. >> There are only a few providers for whom this is implemented and there''s a >> bug in those implementations that''s been copied from one provider to >> another. As a refinement for v2 this could be implemented in Mapstraction >> itself which would save quite a bit of provider code and make the coverage >> complete. >> >> I''ve attached a quick untested "fix" as a patch file. Don''t have time to >> test it right now (is 00:34 here) and I don''t have write access to the v1 >> SVN repository anyway. >> >> Cheers, >> Derek >> >> >> On Thu, Jun 11, 2009 at 12:10 AM, Adam DuVander < >> mapstraction at duvander.com> wrote: >> >>> Hi Dick, >>> >>> The infoDiv and infoBubble text is stored separately, so it means that >>> it''s *possible* to do what you''re asking. >>> >>> To me, it makes sense to keep bubble and infodiv text separate, but I''m >>> not sure about the reasons behind the way it is currently implemented. I''d >>> be interested to get the opinions of others here, especially those who may >>> have made a decision about this in the past. I can''t find anything in the >>> mailing list archives. >>> >>> --Adam >>> --- >>> Adam DuVander >>> I like maps: http://mapscripting.com >>> I like simple: http://adamduvander.com >>> >>> >>> On Jun 10, 2009, at 2:06 PM, Dick Olsson wrote: >>> >>> Hi folks, >>>> >>>> Nice to see the progress of Mapstraction v2! >>>> >>>> I''m the co-maintainer of the Mapstraction module for Drupal [1] and is >>>> currently implementing more features to the module, from the Mapstraction >>>> API. >>>> >>>> Here is one question I have: >>>> >>>> Would it be possible to not have ''setInfoDiv'' override the value set in >>>> ''setInfoBubble''? It would be coolt to be able to show different things in >>>> the bubble and in the info div. >>>> >>>> I''m a PHP-developer and have only worked with mapstraction.js on the API >>>> level. I haven''t looked too deep into the code base, yet. Sorry for that. >>>> >>>> Keep up the good work! >>>> >>>> [1]: http://drupal.org/project/mapstraction >>>> >>>> -- >>>> >>>> Best regards, >>>> >>>> Dick "dixon_" Olsson >>>> Phone: +46733715039 >>>> _______________________________________________ >>>> Mapstraction mailing list >>>> Mapstraction at lists.mapstraction.com >>>> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >>>> >>> >>> _______________________________________________ >>> Mapstraction mailing list >>> Mapstraction at lists.mapstraction.com >>> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >>> >> >> >> >> -- >> Derek Fowler >> m. +44 (0) 7966 512 369 >> e. dezfowler at gmail.com >> > >-- Derek Fowler m. +44 (0) 7966 512 369 e. dezfowler at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090611/945cb6c7/attachment.htm>